495494ce8f
Return a typed error
2 years ago
6686f0437d
Remove x509 prefixes
2 years ago
0263468424
Initial work on name constraints validation
...
Issue #1060
2 years ago
34c6c65671
Pass attestation information to the Sign method
...
Attestation information might be useful in authorizing webhooks
2 years ago
42102d88d5
Fix merge and add unit tests
2 years ago
ee7307bd41
Cherry-pick acme.go from acdfdf3
2 years ago
8fc4a58242
Fix nil pointer exception, missing error
2 years ago
40baf73dff
remove incorrect check on revoked certificate dates, add mutex lock for generating CRLs,
2 years ago
4e19aa4c52
Add cache duration if crl is set
2 years ago
0829f37fe8
Define a default crl cache duration
2 years ago
4a4f7ca9ba
Fix panic if cacheDuration is not set
2 years ago
bb0210e875
Fix typo in linkedca variable
2 years ago
1e098aef5b
Fixes ACMEAttestationFormat comment
2 years ago
66407139e5
Add methods to convert attestation formats
2 years ago
ba42aaf865
Add attestationFormat property in the ACME provisioner
2 years ago
b2119e9f2c
Merge pull request #977 from smallstep/device-attestation
...
Device attestation
2 years ago
fd4e96d1f4
Rename method to IsChallengeEnabled
2 years ago
c77b4ff9c5
Fix linter errors
2 years ago
59c5219a07
Use a type for acme challenges
2 years ago
924082bb49
fix linter errors
2 years ago
d2483f3a70
Merge branch 'master' into crl-support
...
# Conflicts:
# authority/config/config.go
2 years ago
b89f210469
remove fail-email test and add ok-empty-email test
2 years ago
a2749ca8ed
Merge branch 'master' into device-attestation
2 years ago
7a03c43fe2
allow missing Email claim in OIDC tokens, use subject when its missing
2 years ago
1938b1bb34
Merge branch 'master' into herman/fix-template-validation
2 years ago
1d1e024b84
Upgrade to go.step.sm/crypto v0.18.0
2 years ago
f1c63bc38d
Fix challenge mapping
2 years ago
df96b126dc
Add AuthorizeChallenge unit tests
2 years ago
bca311b05e
Add acme property to enable challenges
...
Fixes #1027
2 years ago
6b7b989988
Add provisioner template validation
...
Fixes #1012
2 years ago
693dc39481
Merge branch 'master' into device-attestation
2 years ago
b1e9d5ee86
Revert "Run on plaintext HTTP to support Cloud Run"
...
This reverts commit 09b9673a60
2 years ago
23b8f45b37
Address gosec warnings
...
Most if not all false positives
2 years ago
0c7467ceb2
Allow to automatically configure and linked RA
2 years ago
5e0be92273
Allow option to skip the validation of config
2 years ago
b62f4d1000
Add lgtm comments on some security warnings
2 years ago
a5439c43cd
Remove ciphersuites without Lucky13 countermeasures
...
SHA-256 variants of the CBC ciphersuites don't implement any Lucky13
countermeasures. See http://www.isg.rhul.ac.uk/tls/Lucky13.html and
https://www.imperialviolet.org/2013/02/04/luckythirteen.html .
2 years ago
8bd0174251
Rename field to IsCAServerCert
2 years ago
5df1694250
Add endpoint id for the RA certificate
...
In a linked RA mode, send an endpoint id to group the server
certificates.
2 years ago
eb091aec54
Simplify field names for ProvisionerInfo
2 years ago
21427d5d65
Replace instead of prepend provisioner extension
...
With non standard SANs this will generate the SAN and provisioner
extension in the same order.
2 years ago
369b8f81c3
Use go.step.sm/crypto/kms
...
Fixes #975
2 years ago
e02a190fa7
Merge branch 'master' into device-attestation
2 years ago
3e2729e391
Merge pull request #989 from smallstep/max/disable-ssh-hosts
...
Add attribute to disable SSH Hosts list API
2 years ago
99c9155467
disableSSHHostsListAPI -> disableGetSSHHosts
2 years ago
64744562c6
Send RA provisioner to linkedca.
2 years ago
6b5d3dca95
Add provisioner name to RA info
2 years ago
a1f54921d2
Rename internal field
2 years ago
f9df8ac05f
Remove unused interface
2 years ago
9408d0f24b
Send RA provisioner information to the CA
2 years ago
fb7f57a8df
Add attribute to disable SSH Hosts list API
2 years ago
60671b07d7
Merge branch 'master' into crl-support
...
# Conflicts:
# api/api.go
# authority/config/config.go
# cas/softcas/softcas.go
# db/db.go
2 years ago
09b9673a60
Run on plaintext HTTP to support Cloud Run
2 years ago
fe04f93d7f
all: reformat all go files with the next gofmt (Go 1.19)
...
There are some changes that manually edited, for example using '-' as
default list and grouping imports.
2 years ago
9c049eec5a
Add revoke ssh unit test
2 years ago
ce9a23a0f7
Fix SSH certificate revocation
2 years ago
911cec21da
Merge pull request #943 from smallstep/ssh-renew-provisioner
...
Add provisioner to SSH renewals
2 years ago
94f5b92513
Use proper context in authority package
2 years ago
1be74eca62
Merge branch 'master' into ssh-renew-provisioner
2 years ago
26dd97e718
Merge branch 'master' into context-authority
2 years ago
6b3a8f22f3
Add provisioner to SSH renewals
...
This commit allows to report the provisioner to the linkedca when
a SSH certificate is renewed.
2 years ago
3c4d0412ef
Merge pull request #941 from smallstep/ssh-provisioner
...
Report SSH provisioner
2 years ago
f8148071fb
Merge pull request #915 from smallstep/max/removing-beta
...
exposing authority configuration for provisioner cli commands
2 years ago
5443aa073a
gofmt -s
2 years ago
586e4fd3b5
Update authority/options.go
...
Co-authored-by: Mariano Cano <mariano@smallstep.com>
2 years ago
dd985ce154
Clarify errors when sending renewed certificates
2 years ago
a627f21440
Fix AuthorizeSSHSign tests with extra SignOption
2 years ago
e7d7eb1a94
Add provisioner as a signOption for SSH
2 years ago
293586079a
Store provisioner with SignSSH
...
This change also allows to store the old certificate on renewal on
linkedca or if the db interface supports it.
2 years ago
c8d7ad7ab9
Fix store certificates methods with new interface
2 years ago
de99c3cac0
Report provisioner and parent on linkedca
2 years ago
479eda7339
Improve error message when client renews with expired certificate
...
When a client provides an expired certificate and `AllowAfterExpiry`
is not enabled, the client would get a rather generic error with
instructions to view the CA logs. Viewing the CA logs can be done
when running `step-ca`, but they can't be accessed easily in the
hosted solution.
This commit returns a slightly more informational message to the
client in this specific situation.
2 years ago
bfb406bf70
Fixes for PR review
2 years ago
898ca41268
Merge branch 'master' into context-authority
2 years ago
c695b23e24
Fix check for admin not belonging to policy
2 years ago
25b8d196d8
Couple changes in response to PR
...
- add skipInit option to skip authority initialization
- check admin API status when removing provisioners - no need to check
admins when not using Admin API
2 years ago
8942422973
Add GetID() and add authority to initial context
2 years ago
1e03bbb1af
Change types in the ACMEAdminResponder
2 years ago
f639bfc53b
Use contexts on the new PolicyAdminResponder
2 years ago
d461918eb0
Merge branch 'master' into context-authority
2 years ago
0f4ffa504a
Fix linting issues
2 years ago
7104299119
Add full policy validation in API
2 years ago
105211392c
Don't rely on linkedca model stability in API response bodies
2 years ago
5e9bce508d
Unexport GetPolicy()
2 years ago
60d8b22d89
Change context retrievers to MustTFromContext
2 years ago
43ddcf2efe
Do not use deprecated AuthorizeSign
2 years ago
9147356d8a
Fix linter errors
2 years ago
a8a4261980
Fix authority/admin/api tests
2 years ago
77893ea55c
Change authority policy to use dbPolicy model
2 years ago
4cb74e7d8b
fix linter warnings
2 years ago
d82e51b748
Update AllowWildcardNames configuration name
2 years ago
2b7f6931f3
Change Subject Common Name verification
...
Subject Common Names can now also be configured to be allowed or
denied, similar to SANs. When a Subject Common Name is not explicitly
allowed or denied, its type will be determined and its value will be
validated according to the constraints for that type of name (i.e. URI).
2 years ago
00f181dec3
Use contexts in admin api handlers
2 years ago
623c296555
Create context methods from admin database
2 years ago
48e2fabeb8
Add authority.MustFromContext
2 years ago
9628fa3562
Add methods to store and retrieve an authority from the context.
2 years ago
bddd08d4b0
Remove "proto:" prefix from bad proto JSON messages
2 years ago
6e1f8dd7ab
Refactor policy engines into container
2 years ago
2a7620641f
Fix more PR comments
2 years ago
76112c2da1
Improve error creation and testing for core policy engine
2 years ago
b91affdd34
exposing authority configuration for provisioner cli commands
2 years ago
20f5d12b99
Improve test rigour for reloadPolicyEngines
2 years ago
6264e8495c
Improve policy error handling code coverage
2 years ago
3fa96ebf13
Improve policy errors returned to client
2 years ago
c40a4d2694
Contain policy engines inside provisioner Controller
2 years ago
ef110a94df
Change pointer booleans to regular boolean configuration
2 years ago
e9f5a1eb98
Improve policy bad request handling
2 years ago
b72430f4ea
Block all APIs when using linked deployment mode
2 years ago
fb81407d6f
Fix ACME policy comments
2 years ago
a2cfbe3d54
Fix (part of) PR comments
2 years ago
3eecc4f7bb
Improve test coverage for reloadPolicyEngines
2 years ago
72bbe53376
Add additional policy options
2 years ago
9a21208f22
Add deduplication of policy configuration values
2 years ago
f2f9cb899e
Add conditional defaults to policy protobuf request bodies
2 years ago
647538e9e8
Merge branch 'herman/allow-deny' into herman/allow-deny-options
2 years ago
ad2de16299
Merge branch 'master' into herman/allow-deny
2 years ago
7f9034d22a
Add additional policy options
2 years ago
fe9c3cf753
Merge branch 'master' into ahmet2mir-feat/vault
2 years ago
def9438ad6
Improve handling of bad JSON protobuf bodies
2 years ago
2ca5c0170f
Fix flaky test behavior for protobuf messages
2 years ago
abcad679ff
Merge branch 'master' into herman/allow-deny
2 years ago
8d15a027a7
Fix if-else linting issue
2 years ago
c066694c0c
Allow renew token issuer to be the provisioner name.
...
For consistency with AuthorizeAdminToken, AuthorizeRenewToken will
allow the issuer to be either the fixed string 'step-ca-client/1.0'
or the provisioner name.
2 years ago
99702d3648
Fix case of no authority policy existing
2 years ago
d6be9450be
Merge branch 'master' into herman/allow-deny
2 years ago
30d5d89a13
Improve test coverage for Policy Admin API
2 years ago
d3b6bc3c75
Merge branch 'master' into fix/adminra
2 years ago
ad5aedfa60
Fix backward compatibility in AuthorizeAdminToken
...
This commit validates both new and old issuers.
2 years ago
5f714f2485
Fix tests for AuthorizeRenewToken
2 years ago
674dc3c844
Rename unreleased claim to allowRenewalAfterExpiry for consistency.
2 years ago
4e4d4e882f
Use a fixed string for renewal token issuer.
2 years ago
0a5dc237df
Fix typo in comment.
2 years ago
00cd0f5f21
Apply suggestions from code review
...
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
2 years ago
ea5f7f2acc
Fix SANs for step-ca certificate
...
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
2 years ago
37b521ec6c
Merge branch 'master' into feat/vault
2 years ago
c8c59d68f5
Allow mTLS renewals if the provisioner extension does not exists.
...
This fixes a backward compatibility issue with with the new
LoadProvisionerByCertificate.
2 years ago
256fe113f7
Improve tests for ACME account policy
2 years ago
f2cf9cf828
authority/status: removed the package ( #892 )
2 years ago
af8fcf5b01
Use always LoadProvisionerByCertificate on authority package
2 years ago
1d1e095447
Add tests for LoadProvisionerByCertificate.
2 years ago
0bb15e16f9
Fix missing ACME provisioner option
2 years ago
9797b3350e
Merge branch 'master' into herman/allow-deny
2 years ago
dfdc9c06ed
Fix linter error importShadow
2 years ago
8abd568f03
Merge branch 'master' into fix/adminra
2 years ago
b7e11da480
Merge branch 'master' into feat/linkedra
2 years ago
c55b27a2fc
Refactor admin token to use with RAs.
2 years ago
034b7943fe
Merge branch 'master' into herman/allow-deny
2 years ago
7df52dbb76
Add ACME EAB policy
2 years ago
db337debcd
Load provisioner from the database instead of the extension.
2 years ago
df8ffb35af
Remove unnecessary database in provisioner config.
2 years ago
49c41636cc
implemented some requested changes
2 years ago
53dbe2309b
implemented some requested changes
2 years ago
a607ab189a
requested changes
2 years ago
d417ce3232
implement changes from review
2 years ago
668cb6f39c
missed some mentions of PEM when changing the returned format to DER regarding CRL generation
2 years ago
7d024cc4cb
change GenerateCertificateRevocationList to return DER, store DER in db instead of PEM, nicer PEM encoding of CRL, add Mock stubs
2 years ago
e8fdb703c9
initial support for CRL
2 years ago
150eee70df
Updates based on Herman's feedback
2 years ago
4b9f44982d
Merge branch 'master' into startup-info
2 years ago
43f2c655b9
More info on startup
2 years ago
679e2945f2
Disallow name constraint wildcard notation
2 years ago
96f4c49b0c
Improve how policy errors are returned and used
2 years ago
d8776d8f7f
Add K8sSA SSH user policy back
...
According to the docs, the K8sSA provisioner can be configured
to issue SSH user certs.
2 years ago
571b21abbc
Fix (most) PR comments
2 years ago
1ba1584c7a
Formatted.
2 years ago
a13e58e340
Update GetAuthorityInfo -> GetInfo
2 years ago
90cb6315b1
Progress.
2 years ago
055e75f394
Progress?
2 years ago
bfa4d809fd
Improve middleware test coverage
2 years ago
6da243c34d
Add policy precheck for all admins
2 years ago
628d7448de
Don't return policy in provisioner JSON
2 years ago
2fbdf7d5b0
Merge branch 'master' into herman/allow-deny
2 years ago
0e052fe299
Add authority policy API
2 years ago
00634fb648
api/render, api/log: initial implementation of the packages ( #860 )
...
* api/render: initial implementation of the package
* acme/api: refactored to support api/render
* authority/admin: refactored to support api/render
* ca: refactored to support api/render
* api: refactored to support api/render
* api/render: implemented Error
* api: refactored to support api/render.Error
* acme/api: refactored to support api/render.Error
* authority/admin: refactored to support api/render.Error
* ca: refactored to support api/render.Error
* ca: fixed broken tests
* api/render, api/log: moved error logging to this package
* acme: refactored Error so that it implements render.RenderableError
* authority/admin: refactored Error so that it implements render.RenderableError
* api/render: implemented RenderableError
* api/render: added test coverage for Error
* api/render: implemented statusCodeFromError
* api: refactored RootsPEM to work with render.Error
* acme, authority/admin: fixed pointer receiver name for consistency
* api/render, errs: moved StatusCoder & StackTracer to the render package
2 years ago
955d4cf80d
Add authority.WithX509SignerFunc
...
This change adds a new authority option that allows to pass a callback
that returns the certificate chain and signer used to sign X.509
certificates.
This option will be used by Caddy, they renew the intermediate
certificate weekly and there's no other way to replace it without
re-creating the embedded CA.
Fixes #874
2 years ago
6851842841
Fix unit tests.
2 years ago
580a9c1476
Get linked RA configuration using the linked ca client.
2 years ago
37207793f9
Pass in the resource name regardless of if its a VM or managed identity
2 years ago
7e47c70af2
Remove redundant parameter type declaration
2 years ago
7b605b2d16
Support Azure tokens from managed identities not associated with a VM
2 years ago
5ab79f53be
Fix linter errors
2 years ago
b49307f326
Fix ACME order tests with mock ACME CA
2 years ago
9e0edc7b50
Add early authority policy evaluation to ACME order API
2 years ago
613c99f00f
Fix linting issues
2 years ago
dc23fd23bf
Merge branch 'master' into herman/allow-deny-next
2 years ago
6b620c8e9c
Improve protobuf unmarshaling error handling
2 years ago
082734474b
Merge pull request #845 from vijayjt/azure-user-mi-token
...
WIP: Support Azure tokens generated by managed identities
2 years ago
25cc9a1728
Update authority/authority.go
...
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
2 years ago
9d027c17d0
Send current provisioner on PostCertificate
2 years ago
b401376829
Add current provisioner to AuthorizeSign SignOptions.
...
The original provisioner cannot be retrieved from a certificate
if a linked ra is used.
2 years ago
24a963766e
Pass in the resource name regardless of if its a VM or managed identity
2 years ago
baf3c40fef
Print some basic configuration info on startup
2 years ago
ad8a813abe
Fix linter errors
2 years ago
101ca6a2d3
Check admin subjects before changing policy
2 years ago
4fb38afc57
authority/admin/api: refactored to use the read package
2 years ago
81b0c6c37c
Add API implementation for authority and provisioner policy
2 years ago
6d532045dc
Fix validity check for sshpop provisioner.
2 years ago
c903f00cd4
Rename claim to allowRenewAfterExpiry.
2 years ago
4690fa64ed
Add public methods to retrieve the provisioner extensions.
2 years ago
616490a9c6
Refactor renew after expiry token authorization
...
This changes adds a new authority method that authorizes the
renew after expiry tokens.
2 years ago
79349b4d7c
Add options to use custom renewal methods.
2 years ago
389815642d
Fix tests: certs are truncated to seconds.
2 years ago
8ef8f4f665
Use the provisioner controller in Nebula renewals
2 years ago
259e95947c
Add support for the provisioner controller
...
The claimer, audiences and custom callback methods are now managed
by the provisioner controller in an uniform way.
2 years ago
3c2ff33ca9
Add provisioner controller tests.
2 years ago
fd6a2eeb9c
Add provisioner controller
...
The provisioner controller has the implementation of the identity
function as well as the renew methods with renew after expiry
support.
2 years ago
3ec9a7310c
Fix ACME order identifier allow/deny check
2 years ago
7c541888ad
Refactor configuration of allow/deny on authority level
2 years ago
af53a17bb4
Merge branch 'master' into herman/allow-deny
2 years ago
4822516d72
Remove redundant parameter type declaration
2 years ago
e699244291
Support Azure tokens from managed identities not associated with a VM
2 years ago
15b1049f19
Fix json tag for Azure.ObjectIDs.
2 years ago
6f46cdb432
Merge pull request #829 from vijayjt/new-azure-token-authz-options
...
Add subscription and object ID validation options to Azure provisioner
2 years ago
a79d4af19b
change return value of generateProvisionerConfig to value
...
- always used as value (rather than pointer)
2 years ago
6030f8bc2e
Validate provisioner configuration before storing in DB
2 years ago
b128e37090
Add SubscriptionIDs and ObjectIDs to provisioner-linkedca conversion functions
2 years ago
4a10f2c584
Rename new fields as per feedback to remove AAD from the name
2 years ago
8b68bedffa
Add support for validation of certificate requests using Azure subscription and AAD object IDs. See #735
2 years ago
c3c6f3da72
Merge branch 'master' into herman/allow-deny
2 years ago
abe951d416
Fix name of the variable in comment.
2 years ago
a0cf808393
Make the X5C leaf certificate available to the templates.
...
X509 and SSH templates of the X5C provisioner will have now access
to the leaf certificate used to sign the token using the template
variable .AuthorizationCrt
Fixes #433
2 years ago
c0525381eb
Merge branch 'master' into feat/vault
2 years ago
4ebf43c011
Merge pull request #820 from smallstep/herman/acme-api
...
Refactor ACME Admin API
2 years ago
5b713a564c
Change CM link
2 years ago
5cb23c6029
Merge pull request #804 from smallstep/herman/normalize-ipv6-dns-names
...
Normalize IPv6 hostname addresses
2 years ago
d00729df0b
Refactor ACME Admin API
2 years ago
62690ab52e
Fix linting errors and pin linter version in release action
2 years ago
d384b534c7
Merge pull request #814 from smallstep/x509-enforcer
...
Authority enforcer option
2 years ago
bfa2245abb
Merge branch 'master' into herman/normalize-ipv6-dns-names
2 years ago
e887ccaa07
Ensure the CA TLS certificate represents IPv6 DNS names as IP in cert
...
If an IPv6 domain name (i.e. [::1]) is provided manually in the `ca.json`,
this commit will ensure that it's represented as an IP SAN in the TLS
certificate. Before this change, the IPv6 would become a DNS SAN.
2 years ago
300c19f8b9
Add a custom enforcer that can be used to modify a cert.
2 years ago
88c7b63c9d
Split SSH user and cert policy configuration and execution
2 years ago
acd13cb92d
Merge branch 'master' of github.com:smallstep/certificates into herman/allow-deny
2 years ago
c1424036bf
Merge branch 'master' into herman/allow-deny
2 years ago
c7c5c3c94e
Merge branch 'master' into herman/scep-macos-renewal-fixes
2 years ago
9617edf0c2
Improve internationalized domain name handling
...
This PR improves internationalized domain name handling according
to rules of IDNA and based on the description in RFC 5280, section 7:
https://datatracker.ietf.org/doc/html/rfc5280#section-7 .
Support for internationalized URI(s), so-called IRIs, still needs to
be done.
2 years ago
512b8d6730
Refactor instantiation of policy engines
...
Instead of using the `base` struct, the x509 and SSH policy
engines are now added to each provisioner directly.
2 years ago
066bf32086
Fix part of PR comments
2 years ago
fd9845e9c7
Add cursor and limit to ACME EAB DB interface
2 years ago
3b72d241e0
Add LinkedCA integration for improved SCEP provisioner
2 years ago
868cc4ad7f
Increase test coverage for additional indexes
2 years ago
8838961b68
Merge branch 'master' into hs/acme-eab
2 years ago
716b946e7a
Normalize IPv6 hostname addresses
2 years ago
64680bb16d
Fix PR comments
2 years ago
3612eefc31
Cleanup
2 years ago
6440870a80
Clean up, improve test cases and coverage
2 years ago
1e808b61e5
Merge logic for X509 and SSH policy
2 years ago
6bc301339f
Improve test case and code coverage
2 years ago
91d51c2b88
Add allow/deny to Nebula provisioner
2 years ago
d9c56d67cc
Merge branch 'master' into herman/allow-deny
2 years ago
Mariano Cano
Raal Goff
Mariano Cano
Herman Slatman
Max
Brandon Weeks
Shulhan
Panagiotis Siatras
Carl Tashian
vijayjt
Herman Slatman