From afeeb9e8ae93f5952e4c9e08df338f2b4c9ef014 Mon Sep 17 00:00:00 2001
From: Atinoda <61033436+Atinoda@users.noreply.github.com>
Date: Tue, 26 Mar 2024 09:48:16 +0000
Subject: [PATCH] Fix launch arg array handling

---
 README.md                    | 4 +++-
 scripts/docker-entrypoint.sh | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
 mode change 100644 => 100755 scripts/docker-entrypoint.sh

diff --git a/README.md b/README.md
index f211366..21b33ea 100644
--- a/README.md
+++ b/README.md
@@ -153,7 +153,9 @@ The following are known issues and they are planned to be investigated. Testing
 - `superbooga`/`superboogav2`: Crashes on startup
 
 ## Kubernetes
-Please see [EXTRA_LAUNCH_ARGS are not honored #25](https://github.com/Atinoda/text-generation-webui-docker/issues/25) for fixing deployments. *Thanks to @jrsperry for reporting, and @accountForIssues for sharing a workaround (TLDR: Escape space characters with `\ `, instead of writing as ` ` .)*
+~~Please see [EXTRA_LAUNCH_ARGS are not honored #25](https://github.com/Atinoda/text-generation-webui-docker/issues/25) for fixing deployments. *Thanks to @jrsperry for reporting, and @accountForIssues for sharing a workaround (TLDR: Escape space characters with `\ `, instead of writing as ` ` .)*~~
+
+From `snapshot-2024-03-24` onwards, this workaround should not be necessary - but existing installations using it should remain functional with no required changes. **Please report if you have an issue!** This notice will be removed in due course. *Thanks to @[Artem-B](https://github.com/Artem-B) for finding the root cause and contributing a fix.*
 
 # Contributions
 Contributions are welcomed - please feel free to submit a PR. More variants (e.g., AMD/ROC-M support) and Windows support can help lower the barrier to entry, make this technology accessible to as many people as possible, and push towards democratising the severe impacts that AI is having on our society.
diff --git a/scripts/docker-entrypoint.sh b/scripts/docker-entrypoint.sh
old mode 100644
new mode 100755
index 2360f33..c2a05c4
--- a/scripts/docker-entrypoint.sh
+++ b/scripts/docker-entrypoint.sh
@@ -63,7 +63,7 @@ echo "=== Image build date: $BUILD_DATE ==="
 
 # Assemble CMD and extra launch args
 eval "extra_launch_args=($EXTRA_LAUNCH_ARGS)"
-LAUNCHER=($@ $extra_launch_args)
+LAUNCHER=($@ ${extra_launch_args[@]})
 
 # Launch the server with ${CMD[@]} + ${EXTRA_LAUNCH_ARGS[@]}
 "${LAUNCHER[@]}"