From 522807d25d4123e77fb6a6d7c72e740dc5703069 Mon Sep 17 00:00:00 2001 From: yzqzss Date: Mon, 29 May 2023 10:48:05 +0800 Subject: [PATCH 1/2] fix: incorrect xml space attr in --- dumpgenerator.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dumpgenerator.py b/dumpgenerator.py index c5d1d80..aa84424 100755 --- a/dumpgenerator.py +++ b/dumpgenerator.py @@ -1075,10 +1075,12 @@ def makeXmlFromPage(page): size = rev['size'] else: size = 0 + text_element = E.text(to_unicode(rev["*"]), bytes=to_unicode(size)) + text_element.set("{http://www.w3.org/XML/1998/namespace}space", "preserve") revision = E.revision( E.id(to_unicode(rev['revid'])), E.timestamp(rev['timestamp']), - E.text(to_unicode(rev['*']), space="preserve", bytes=to_unicode(size)), + text_element, ) # The username may be deleted/suppressed if 'user' in rev: From e979adfbebaa8d9fb91408bf07678d3081fcaac7 Mon Sep 17 00:00:00 2001 From: yzqzss Date: Mon, 29 May 2023 10:49:56 +0800 Subject: [PATCH 2/2] remove empty if no comment provided --- dumpgenerator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dumpgenerator.py b/dumpgenerator.py index aa84424..6dd94e6 100755 --- a/dumpgenerator.py +++ b/dumpgenerator.py @@ -1090,7 +1090,7 @@ def makeXmlFromPage(page): )) else: revision.append(E.contributor(deleted="deleted")) - if 'comment' in rev: + if 'comment' in rev and rev["comment"]: revision.append(E.comment(to_unicode(rev['comment']))) if 'contentmodel' in rev: revision.append(E.model(rev['contentmodel']))