From dd0228ce1f708b12d7b1579438f63fda37c5bb48 Mon Sep 17 00:00:00 2001 From: pukkandan Date: Sun, 19 Dec 2021 20:25:01 +0530 Subject: [PATCH] Remove known invalid thumbnails from `info_dict` Related: https://github.com/yt-dlp/yt-dlp/issues/980#issuecomment-997396821 --- yt_dlp/YoutubeDL.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/yt_dlp/YoutubeDL.py b/yt_dlp/YoutubeDL.py index ec69151d7..b5a2581c6 100644 --- a/yt_dlp/YoutubeDL.py +++ b/yt_dlp/YoutubeDL.py @@ -3685,7 +3685,7 @@ class YoutubeDL(object): self.write_debug(f'Skipping writing {label} thumbnail') return ret - for t in thumbnails[::-1]: + for idx, t in list(enumerate(thumbnails))[::-1]: thumb_ext = (f'{t["id"]}.' if multiple else '') + determine_ext(t['url'], 'jpg') thumb_display_id = f'{label} thumbnail {t["id"]}' thumb_filename = replace_extension(filename, thumb_ext, info_dict.get('ext')) @@ -3706,6 +3706,7 @@ class YoutubeDL(object): ret.append((thumb_filename, thumb_filename_final)) t['filepath'] = thumb_filename except network_exceptions as err: + thumbnails.pop(idx) self.report_warning(f'Unable to download {thumb_display_id}: {err}') if ret and not write_all: break