Archives
/
koreader
mirror of https://github.com/koreader/koreader
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

cre: tweak current page highlights detection

Browse Source 
No need to use current page and xpointers. We can use
'pos', in both scroll and page modes, as it is always
accurate to show the y of the current view.
pull/4786/head
poire-z 5 years ago
parent 1a4faad17c
commit 0948a4b656
2 changed files with 30 additions and 60 deletions
Show Stats Download Patch File Download Diff File

45
frontend/apps/reader/modules/readerhighlight.lua
Unescape Escape View File

@ -207,7 +207,7 @@ function ReaderHighlight:onTapXPointerSavedHighlight(ges)
-- showing menu...). We might want to cache these boxes per page (and -- showing menu...). We might want to cache these boxes per page (and
-- clear that cache when page layout change or highlights are added -- clear that cache when page layout change or highlights are added
-- or removed). -- or removed).
local cur_page, cur_page2, cur_scroll_top, cur_scroll_bottom local cur_view_top, cur_view_bottom
local pos = self.view:screenToPageTransform(ges.pos) local pos = self.view:screenToPageTransform(ges.pos)
for page, _ in pairs(self.view.highlight.saved) do for page, _ in pairs(self.view.highlight.saved) do
local items = self.view.highlight.saved[page] local items = self.view.highlight.saved[page]
@ -216,37 +216,22 @@ function ReaderHighlight:onTapXPointerSavedHighlight(ges)
local pos0, pos1 = items[i].pos0, items[i].pos1 local pos0, pos1 = items[i].pos0, items[i].pos1
-- document:getScreenBoxesFromPositions() is expensive, so we -- document:getScreenBoxesFromPositions() is expensive, so we
-- first check this item is on current page -- first check this item is on current page
local is_in_view = false if not cur_view_top then
if self.view.view_mode == "page" then -- Even in page mode, it's safer to use pos and ui.dimen.h
if not cur_page then -- than pages' xpointers pos, even if ui.dimen.h is a bit
cur_page = self.ui.document:getPageFromXPointer(self.ui.document:getXPointer()) -- larger than pages' heights
if self.ui.document:getVisiblePageCount() > 1 then cur_view_top = self.ui.document:getCurrentPos()
cur_page2 = cur_page + 1 if self.view.view_mode == "page" and self.ui.document:getVisiblePageCount() > 1 then
end cur_view_bottom = cur_view_top + 2 * self.ui.dimen.h
end else
local page0 = self.ui.document:getPageFromXPointer(pos0) cur_view_bottom = cur_view_top + self.ui.dimen.h
local page1 = self.ui.document:getPageFromXPointer(pos1)
local start_page = math.min(page0, page1)
local end_page = math.max(page0, page1)
if start_page <= cur_page and end_page >= cur_page then
is_in_view = true
elseif cur_page2 and start_page <= cur_page2 and end_page >= cur_page2 then
is_in_view = true
end
else
if not cur_scroll_top then
cur_scroll_top = self.ui.document:getPosFromXPointer(self.ui.document:getXPointer())
cur_scroll_bottom = cur_scroll_top + self.ui.dimen.h
end
local spos0 = self.ui.document:getPosFromXPointer(pos0)
local spos1 = self.ui.document:getPosFromXPointer(pos1)
local start_pos = math.min(spos0, spos1)
local end_pos = math.max(spos0, spos1)
if start_pos <= cur_scroll_bottom and end_pos >= cur_scroll_top then
is_in_view = true
end end
end end
if is_in_view then local spos0 = self.ui.document:getPosFromXPointer(pos0)
local spos1 = self.ui.document:getPosFromXPointer(pos1)
local start_pos = math.min(spos0, spos1)
local end_pos = math.max(spos0, spos1)
if start_pos <= cur_view_bottom and end_pos >= cur_view_top then
local boxes = self.ui.document:getScreenBoxesFromPositions(pos0, pos1, true) -- get_segments=true local boxes = self.ui.document:getScreenBoxesFromPositions(pos0, pos1, true) -- get_segments=true
if boxes then if boxes then
for index, box in pairs(boxes) do for index, box in pairs(boxes) do

45
frontend/apps/reader/modules/readerview.lua
Unescape Escape View File

@ -495,7 +495,7 @@ function ReaderView:drawXPointerSavedHighlight(bb, x, y)
-- showing menu...). We might want to cache these boxes per page (and -- showing menu...). We might want to cache these boxes per page (and
-- clear that cache when page layout change or highlights are added -- clear that cache when page layout change or highlights are added
-- or removed). -- or removed).
local cur_page, cur_page2, cur_scroll_top, cur_scroll_bottom local cur_view_top, cur_view_bottom
for page, _ in pairs(self.highlight.saved) do for page, _ in pairs(self.highlight.saved) do
local items = self.highlight.saved[page] local items = self.highlight.saved[page]
if not items then items = {} end if not items then items = {} end
@ -504,37 +504,22 @@ function ReaderView:drawXPointerSavedHighlight(bb, x, y)
local pos0, pos1 = item.pos0, item.pos1 local pos0, pos1 = item.pos0, item.pos1
-- document:getScreenBoxesFromPositions() is expensive, so we -- document:getScreenBoxesFromPositions() is expensive, so we
-- first check this item is on current page -- first check this item is on current page
local is_in_view = false if not cur_view_top then
if self.view_mode == "page" then -- Even in page mode, it's safer to use pos and ui.dimen.h
if not cur_page then -- than pages' xpointers pos, even if ui.dimen.h is a bit
cur_page = self.ui.document:getPageFromXPointer(self.ui.document:getXPointer()) -- larger than pages' heights
if self.ui.document:getVisiblePageCount() > 1 then cur_view_top = self.ui.document:getCurrentPos()
cur_page2 = cur_page + 1 if self.view_mode == "page" and self.ui.document:getVisiblePageCount() > 1 then
end cur_view_bottom = cur_view_top + 2 * self.ui.dimen.h
end else
local page0 = self.ui.document:getPageFromXPointer(pos0) cur_view_bottom = cur_view_top + self.ui.dimen.h
local page1 = self.ui.document:getPageFromXPointer(pos1)
local start_page = math.min(page0, page1)
local end_page = math.max(page0, page1)
if start_page <= cur_page and end_page >= cur_page then
is_in_view = true
elseif cur_page2 and start_page <= cur_page2 and end_page >= cur_page2 then
is_in_view = true
end
else
if not cur_scroll_top then
cur_scroll_top = self.ui.document:getPosFromXPointer(self.ui.document:getXPointer())
cur_scroll_bottom = cur_scroll_top + self.ui.dimen.h
end
local spos0 = self.ui.document:getPosFromXPointer(pos0)
local spos1 = self.ui.document:getPosFromXPointer(pos1)
local start_pos = math.min(spos0, spos1)
local end_pos = math.max(spos0, spos1)
if start_pos <= cur_scroll_bottom and end_pos >= cur_scroll_top then
is_in_view = true
end end
end end
if is_in_view then local spos0 = self.ui.document:getPosFromXPointer(pos0)
local spos1 = self.ui.document:getPosFromXPointer(pos1)
local start_pos = math.min(spos0, spos1)
local end_pos = math.max(spos0, spos1)
if start_pos <= cur_view_bottom and end_pos >= cur_view_top then
local boxes = self.ui.document:getScreenBoxesFromPositions(pos0, pos1, true) -- get_segments=true local boxes = self.ui.document:getScreenBoxesFromPositions(pos0, pos1, true) -- get_segments=true
if boxes then if boxes then
for _, box in pairs(boxes) do for _, box in pairs(boxes) do

Write Preview
Loading…
Cancel
Save