Menu: Actually hide PlatformNav if !hasKeys

Returning {} just leads to a present but blank entry

(Also, nobody notice that the capcheck was wrong inside platnav anyway ;p).
reviewable/pr10821/r1
NiLuJe 10 months ago
parent f4aca567ef
commit ac1358e0f0

@ -465,7 +465,9 @@ To:
end end
-- settings > Navigation; this mostly concerns platform-specific features or physical keys, and applies *everywhere* -- settings > Navigation; this mostly concerns platform-specific features or physical keys, and applies *everywhere*
self.menu_items.platform_navigation_features = require("ui/elements/platform_navigation") if Device:hasKeys() then
self.menu_items.platform_navigation_features = require("ui/elements/platform_navigation")
end
-- settings tab - Document submenu -- settings tab - Document submenu
self.menu_items.document_metadata_location_move = { self.menu_items.document_metadata_location_move = {

@ -241,7 +241,9 @@ function ReaderMenu:setUpdateItemTable()
self.menu_items.page_turns = require("ui/elements/page_turns") self.menu_items.page_turns = require("ui/elements/page_turns")
end end
-- While also related to page turns, this mostly concerns platform-specific features or physical keys, and applies *everywhere* -- While also related to page turns, this mostly concerns platform-specific features or physical keys, and applies *everywhere*
self.menu_items.platform_navigation_features = require("ui/elements/platform_navigation") if Device:hasKeys() then
self.menu_items.platform_navigation_features = require("ui/elements/platform_navigation")
end
-- insert DjVu render mode submenu just before the last entry (show advanced) -- insert DjVu render mode submenu just before the last entry (show advanced)
-- this is a bit of a hack -- this is a bit of a hack
if self.ui.document.is_djvu then if self.ui.document.is_djvu then

@ -1,15 +1,9 @@
local Device = require("device") local Device = require("device")
-- Everything in there requires physicla page turn keys ;).
if Device:hasKeys() then
-- No menu entry at all if we don't have any
return {}
end
local Event = require("ui/event") local Event = require("ui/event")
local UIManager = require("ui/uimanager") local UIManager = require("ui/uimanager")
local _ = require("gettext") local _ = require("gettext")
-- This whole menu is hidden behind a hasKeys device cap.
local PlatformNav = { local PlatformNav = {
text = _("Page turn behavior"), -- Mainly so as to differentiate w/ "Page Turns" when in readermenu... text = _("Page turn behavior"), -- Mainly so as to differentiate w/ "Page Turns" when in readermenu...
sub_item_table = { sub_item_table = {

Loading…
Cancel
Save