11 Commits (master)

Author	SHA1	Message	Date
NiLuJe	fadee1f5dc	Clarify our OOP semantics across the codebase (#9586) ... Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.	2 years ago
yparitcher	f5dc7b4539	Dispatcher: Revamp sections and item order	3 years ago
Frans de Jonge	fd51671478	[chore] Change single quotes to double quotes (#6949) ... *Especially* in the hello world plugin.	3 years ago
yparitcher	602e0b3feb	ldoc fixes	4 years ago
yparitcher	433b82f162	Dispatcher: allow registering actions at runtime	4 years ago
Frans de Jonge	1cba60765b	[feat] MenuSorter: add sorting_hint support (#4399) ... By adding a `sorting_hint` to a menu item, the program will put orphaned items in the relevant (sub)menu instead of in the first menu with a NEW prefix. Fixes #4393.	5 years ago
Robert	5344e0b672	[Fix] Don't load disabled plugins (#4169)	6 years ago
Robert	4428ecb422	Plugin manager (#4159) ... Also adds descriptions to all plugins.	6 years ago
Qingping Hou	1461574894	Support configurable extra plugin lookup path (#2693) ... * plugin loader(feat): support loading plugins from user defined directories Extra plugin lookup paths can be set in global reader setting via key `extra_plugin_paths`. Value of the key can either be a string or an array of strings. * build(fix): also purge non-exist plugins on build * plugin: migrate debug plugin to menu sorter	7 years ago
Hzj_jie	ce6bc3df8d	Implement keepalive plugin (#2456)	7 years ago
Hzj_jie	c662ca4cc8	Load plugins also in FileManager (#2426) ... added is_doc_only plugin attribute	7 years ago