6 Commits (master)

Author	SHA1	Message	Date
NiLuJe	da65ac8b02	Cleanup various varargs shenanigans (#9624) ... * Iterate over varargs directly via select if possible * Use table.pack otherwise (https://github.com/koreader/koreader-base/pull/1535). * This allows us to simplify a few Logger calls, as logger now handles nil values.	2 years ago
NiLuJe	fadee1f5dc	Clarify our OOP semantics across the codebase (#9586) ... Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.	2 years ago
NiLuJe	23cd7e24bb	Minor Lua I/O cleanups (#8921) ... Mostly making sure we always explicitly close io handles.	2 years ago
Aleksa Sarai	d0d2d0d1d6	*: luacheck fixes (#8368) ... These weren't caught during the Japanese support plugin review. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>	3 years ago
Frans de Jonge	59710ec67a	[chore] Fix todo and fixme tags (#8365) ... Slightly overlooked in #8312.	3 years ago
Aleksa Sarai	3d4e54c7e6	plugins: add Japanese Support plugin ... This plugin provides support for Japanese deinflection during lookup as well as making long-hold word selection actually select whole words properly. With this plugin, word lookups in Japanese text in KOReader become much easier, and no longer requires users to use special dictionaries that have synonym-based deinflection rules defined (which were always fairly annoying to use). The basic idea and deinflection data for this plugin come from Yomichan (which is also a GPL-3.0+ project), but everything was implemented specifically for KOReader. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>	3 years ago