Commit Graph

172 Commits (99045b431104904d3391a3d5ed01566356f76c24)

Author SHA1 Message Date
Frans de Jonge 5fb0f6efc1 FileManager typography: dashes to en-dashes (#4151) 6 years ago
Robert 7e6802737e Sorting: adds Sort by name - mixed files and folders (#4140)
Also moves the 2 Sort by percent in a sub-menu
6 years ago
alethiophile 637abfdf84 Various changes to sorting (#4067)
Don't consider sidecar file when sorting by access time.
Rename 'sort by title' to 'sort by filename':
This is in accordance with the actual function of the code, which
uses filename rather than title as specified in file metadata.
6 years ago
Robert 19b1c919d6 FileChooser, PathChooser: show current path in header (#4125) 6 years ago
Frans de Jonge a0825ecf03 [fix] Don't crash when trying to go to deleted folders (#4110) 6 years ago
Robert e5a33ac6d9 Add "Open random document" to Plus menu (#4103) 6 years ago
poire-z 6877ade4fd
Remove cre cache file when deleting a book (#4022)
Store the cache file path in book settings, so we can
delete it too when deleting the book.
6 years ago
NiLuJe 5871132c25
UI Behavior tweaks (#3983)
* Switch all initial highlights to "fast" update

i.e., everything that does an invert
Plus a few other things that refresh small UI elements onTap
Re #3130

* Tweak refreshtype for a number of widgets:
  * Fix iconbutton dimen
  * Make touchmenu flash on close & initial menu popup. Full-screen on close.
  * Use flashing updates when opening/closing dictionary popup. Full-screen on close.
  * Switch FileManager to partial.
    It's mostly text, and we want flash promotion there.
  * Make configdialog & menu flash on exit
  * Make FLWidget flash on close
  * virtualkeyboard: flash on layout change & popup.
  * Potentially not that great workaround to ensure we actually see the
highlights in the FM's chevrons
  * Flash when closing BookStatus Widget
  * Optimize away a quirk of the dual "fast" update in touchmenu

* Promote updates to flashing slightly more agressively.

* Document what each refreshtype actually does.

With a few guidelines on their optimal usecases.

* Switch remaining scheduleIn(0.0) to nextTick()

* Tighter scheduling timers

Shaving a hundred ms off UI callbacks...

* Cache FFI C Library namespace

* Ask MuPDF to convert pixmaps to BGR on Kobo

Fix #3949

* Mention koxtoolchain in the README

re #3972

* Kindle: Handle *all* fonts via EXT_FONT_DIR instead of bind mounts insanity

* Make black flashes in UI elements user-configurable

(All or nothing).

* Jot down some random KOA2 sysfs path
6 years ago
onde2rock 5aacc761e1 [UX] Implement back_to_exit option (#3838)
Also goes back to File Manager as default view first.
6 years ago
onde2rock e502bf04d3 [feat, UX] Support the virtualKeyboard on non touch-device (#3796)
* [VirtualKeyboard] Add support for keynaviguation

Also rename the variable "layout" to "keyboard_layout" because conflict
with the layout from the focusmanager

* Make the goto dialog compatible with key naviguation

My solution is to change the order of the widget. The last one will the
virtualkeybard so it catch all the keybinding, and below it, make the
dialog "is_always_active = true" so it can receive touch event.

* Correctly show the virtual keyboard on dpad devices

* change the order to call the virtualKeyboard so it end up on top

* Handle the multi input dialog

* Support reopening the virtualKeyboard by the Press key

* add check focusmanager

* Fix https://github.com/koreader/koreader/issues/3797

* MultiInputDialog : Now work on non touch-device

* Set the virtualkeyboard to be a modal widget

* Fix the layout in multiinputwidget

* Fix for the various combination of
hasKeys,hasDpad,isTouchDevice

* [Focusmanager] Better handling of malformed layout
6 years ago
poire-z 5e47a83e6a
UIManager: avoid painting widgets covered by a full screen widget (#3770)
Navigating the TOC, viewing a full screen image, browsing
reading stats... would call paintTo() on ReaderUI (so, asking
the engine to render the page) or FileManager (so, rendering cover
images) even though their content is hidden.
Widgets registering to UIManager have to explicitely states
they cover the full screen (UIManager can't know, parts of their
dimen may be transparent, e.g. if it is a CenterContainer).
6 years ago
onde2rock e8aab49ee9 Kindle4NT improvements (#3745)
* [device][kindle4] add fake event to kindle4

* modify focusmanager to allow for more complex layout

The focusmanager now naviguate the layout by avoiding nil value
instead of relying on table lenght. It should be completely backward
compatible

* add Dpad naviguation to the touchmenu

* fix crash because virtualkeyboard on non touch device

the kindle4NT has no keyboard nor touch, the fix open the virtual
keyboard so koreader dont crash but it's not useable

* Enable device with keys to use the touchmenu

* Don't get stuck in reader progress statistics plugin

* [underlinecontainer] Fix and remove unused function

References #1898.
6 years ago
Frans de Jonge ced9e45d92
[fix] DocumentRegistry: don't create empty sdr and add hasProvider() (#3675)
As suggested by @poire-z https://github.com/koreader/koreader/pull/3653#issuecomment-364663156
6 years ago
Frans de Jonge f6ca1c7c0a
[feat] Open with: choose which engine to use for file (#3653)
Fixes #3345

* Add SVG to MuPDF filetypes
6 years ago
Robert 6e87735b79 Filemanager - sort by percent of book (#3614) 6 years ago
Robert a66d657195 Update History and Last open document when move (cut and paste) file (#3607) 6 years ago
Robert d5d12998f6 Fix folder path truncation in filemanager with utf8 chars (#3599) 6 years ago
Robert d163f8281d Menu: configure number of items per page, wrap entries (#3589)
Configure number of items per page (from 6 to 24) - default is 14
Allow filenames to wrap so that we can see the full name
Used by File browser, History, Search Result, Bookmarks, Table of contents (only single line), File chooser, OPDS catalog
6 years ago
Robert 22a8cfde7c Fix missing createFolder() function and fix KOReader File Browser is no longer tappable (#3576) 6 years ago
Robert 6f41cecab2 Add info when copy or cut file (#3571) 6 years ago
Robert 227584de22 New option - create new directory (#3555) 6 years ago
Robert 79517eb166 Truncate path in filemanager (#3565) 6 years ago
Robert 1d1b005b1a
copying file with .sdr (#3563) 7 years ago
Robert b855eff1b9
Remove not empty folder (#3562) 7 years ago
poire-z 17bbf68dac [Fix] actually use 'reverse_collate' saved setting (#3532) 7 years ago
poire-z 591dc2119c FileBrowser: optimize 'change page to show last file'
This feature, introduced some days ago, was actually
doing 2 updateItems calls: the initial one, and a second
to switch to focused_file page (cheap with classic display mode,
less cheap with CoverBrowser modes).
This change allows doing that in a single call.
7 years ago
poire-z 29707bd664 FileBrowser: change page to show last file or previous subdir (#3351)
When going from reader to filemanager, we are in the directory
containing the last_file. With this, we will also be on the page
showing this file.
When in filemanager and going up (".."), we will also be on the
page containing the directory we came from.
7 years ago
Frans de Jonge 0d7999e7a5 [fix] Add hold_callback to IconButton (#3271)
Also fix path display update.

Fixes #3270.
7 years ago
Robert af356a819b [fix] Avoid crash when set home (#3269) 7 years ago
Frans de Jonge 0fc5a378bc [UX] Add home button (#3263)
Tap to go HOME. Hold to set current folder as HOME. When no HOME is set yet tap also asks to set current folder as HOME.

See https://github.com/koreader/koreader/issues/2957#issuecomment-308513062

Closes #3200.
7 years ago
Frans de Jonge 9eb073a524 [travis] Add protection against unscaled sizes
As pointed out by @poire-z

* [fix, UX] SkimToWidget scaling

* [fix] Button scaling

* [fix, UX] Scale ProgressWidget

* [fix, UX] Scale confirmbox

* [fix, UX] Scale just about everything
7 years ago
poire-z 4d18ac1100 Some History fixes and enhancements (#3247)
Made the onHold buttons table similar to the one of File browser.
Added "Purge .sdr" and "Delete" to these buttons.
Moved the purgeSettings and removeFileFromHistoryIfWanted
logic into filemanagerutil functions.
Stay on the same page when manipulating history (previously, we were
always put back on first page).
Really keep deleted files in history (unless setting says otherwise).
Show deleted files in grey or dimmed in classic History and all
CoverBrowser display modes.
7 years ago
poire-z d4fd0b9428 frontlight on kobo: a few fixes (#3163)
* frontlight on kobo: a few fixes

Rewritten to not update NickelConf on every change, and never
if KOBO_SYNC_BRIGHTNESS_WITH_NICKEL = false.
Reintroduce global settings frontlight_intensity and
is_frontlight_on to keep level and state across koreader
sessions.
Fix a few of the remaining issues on kobo light.
Ensure settings are saved when rebooting/powering off from
File browser.

* Ensure untoggle works when starting with light off
7 years ago
poire-z 9c08236b70 Update 'lastfile' if autoremove_deleted_items_from_history
For people who set autoremove_deleted_items_from_history to true,
file is removed from history when Deleted or 'Purge .sdr'. This also
update lastfile to the new top in history if needed.
7 years ago
poire-z 3cf419defa Purge .sdr: also remove .old backup file
Otherwise, this .old backup is used when re-opening the document,
and we could never reset docsettings.
7 years ago
Frans de Jonge 6bdb96c0f8 [UX] FileManager: add ConfirmBox for purge .sdr
Notified of destructive action without confirmation in https://www.mobileread.com/forums/showthread.php?p=3566978#post3566978
7 years ago
Frans de Jonge 23cd585fae Support history as default view for filemanager (#3058)
Fixes #2774

* make history view borderless
* add new menu for what to start with

Should combine nicely with #2940
7 years ago
poire-z 17656778b1 Book information: refactored and additional features
- Factored out duplicate code from filemanager.lua and filemanagerhistory.lua
to new filemanagerbookinfo.lua (and other common code to filemanagerutil.lua).
- Uses sidecar files' new doc_props and doc_pages settings, or fallback to
old 'stats' settings, or to opening document.
- Shows filename, filetype and directory.
- Shows description (Hold to see whole truncated text), keywords, and
cover image (tap to extract image from document and display it if available).
- Book information now available from reader menu, to display info about
the currently opened book.
- Convert possibly HTML description to plain text via added
util.htmlToPlainTextIfHtml() (for simple HTML conversion).
7 years ago
Hzj_jie 30378eb2a8 Add restart koreader function and ensure FlushSettings event can be delivered to all widgets (#2772) 7 years ago
poire-z 9e346f5559 Allow wikipedia lookup from filemanager
Also allow taking screenshot when on dictionary window.
7 years ago
Qingping Hou 23c2955500 chore: style cleanup for infomessage 7 years ago
Frans de Jonge e1aa57f27e Font: unify font styling 7 years ago
Qingping Hou fd862f5e28 plugin(fix): catch plugin crash at init time 7 years ago
Frans de Jonge 9b2128ecb8 FileConverter added with local Markdown to HTML conversion (#2737)
* FileConverter added with local Markdown to HTML conversion
7 years ago
Frans de Jonge 1c25d0fd1b Language: improve confirmboxes
Generic "OK" buttons should be avoided. Thanks to @lightonflux for pointing this out https://github.com/koreader/koreader/issues/2555#issuecomment-291039945
7 years ago
Frans de Jonge da3ff5e336 History: add 'autoremove_deleted_items_from_history' setting 7 years ago
Frans de Jonge 6458c8e9eb File Manager: rename to "KOReader File Browser" and add up arrow to ".."
This should make it clearer to new users what's going on. Fixes #2529.
7 years ago
Frans de Jonge fed22b509d FileManager: rename hasSidecarDir to hasSidecarFile
Fixes #2550

Cf. b502047635
7 years ago
Zijie He 4f1cabcdbc Improve several outputs 7 years ago
Hzj_jie 726b15ad01 More sorting orders in file manager (#2535) 7 years ago
Zijie He faaca028e7 Remove empty sidecar folder 7 years ago
Zijie He b502047635 Removing metadata file instead of purging .sdr folder 7 years ago
Hzj_jie f91ad679d9 swithItemTable -> switchItemTable 7 years ago
Qingping Hou f95ad00b9e feat: add logger module & rewrite kobo suspend script in lua 7 years ago
Hzj_jie 5bda44473d Add dictionary to filemanager 7 years ago
robert00s ae9261b685 Fix #2440 8 years ago
Hzj_jie c662ca4cc8 Load plugins also in FileManager (#2426)
added is_doc_only plugin attribute
8 years ago
Robert 93e075feb6 Adding the buttondialogtitle widget and show long filename in filemanager (#2414) 8 years ago
poire-z 949e5ba54d FileManager: added button to purge sidecar directory (#2391)
Also move its sidecar directory when moving a file.
8 years ago
Qingping Hou 88ab21c62c minor: change setting names for home_dir_name 8 years ago
Bastien Dejean b3d58fba00 Don't try to set the value of fm_screen_mode
I'm not sure what the original intention was, but in practice, the user
experience regarding the way this setting is saved is horrible: it seems
to change randomly and once the orientation is changed from portrait to
landscape, the only way to fix it is to edit `settings.reader.lua`.
8 years ago
Bastien Dejean 58b6c94a8d Generalize and consolidate tildify
- Don't do any substitution unless `home_dir_name` exists.

- Don't rely on `gsub` because it might interpret some characters in
  `home_dir` as magical (and might also replace a match not starting at
  the beginning of `path`).
8 years ago
Bastien Dejean 283a113aaa Handle corner case in tildify 8 years ago
Bastien Dejean 2f5935411a Replace the home dir by ~ in the FM's current path
This mirrors the well known shell convention and release the user from
a needlessly verbose description of the current path.
8 years ago
Bastien Dejean 83f18d6d77 Properly spell the title of the file manager
Us humans can handle spaces in titles.
8 years ago
robert00s 886e2d6cb1 display document metadata (#2307)
display document metadata in file manager and history menu
8 years ago
Huang Xin b8f23d162d filemanager(fix): refresh banner in filemanager insteand of TextWidget 8 years ago
Hzj_jie 400e63a463 Resolve review comments 8 years ago
Hzj_jie 493ff00609 Add path in file manager 8 years ago
Qingping Hou 2e417cfbd8 filemanager(refactor): use purge method from docsettings 8 years ago
Huang Xin f718b0669f Merge pull request #2045 from koreader/defaults
defaults(refactor): remove global hack in filemanagersetdefaults
8 years ago
Qingping Hou ac03cd241f fm(fix): close filemanager before showReader
This removes filemanager from UI widget stack so it does not listen
to events sent to the reader. Before this patch, screenshot event will
be sent to filemanager.
8 years ago
Qingping Hou 60587e08c6 defaults(refactor): remove global hack in filemanagersetdefaults
also added screensaver folder setting dialog for kobo
8 years ago
chrox 92184f0199 fix #1985 by always return to the parent dir of current doc in the FileManager 8 years ago
Frans de Jonge 5638819f25 Removed a bunch of "successfully", replaced an ellipsis, and some deviant spellings of KOReader. 8 years ago
zijiehe 8861365264 Add rename function for filemanager 8 years ago
Qingping Hou 6a6469fa09 more luacheck fixes 8 years ago
Qingping Hou fb0606aa9c style(FM): rename internal only method into function 8 years ago
Qingping Hou 34515484d1 fix: remove invalid setDirty in FileManager:restoreScreenMode 8 years ago
Qingping Hou d1ca8bc494 fix(filemanager): delete document with settings 8 years ago
Qingping Hou 7caeae8701 fix: make screenshoter always active for filemanager 8 years ago
Qingping Hou 6fe9f7870b chore: more luacheck fixes 9 years ago
Qingping Hou 3b92bdc084 feat: support screenshot in filemanager 9 years ago
Qingping Hou 186673587e chore: fix some of the luacheck errors 9 years ago
chrox 98515a2210 Fix filemanager cp/mv/rm operations not work on Android 9 years ago
chrox 69e6b6b9cb hold on directory in filemanager can set the it as HOME directory
and this "HOME" directory will override the command line option passed to
koreader.

This patch implements #1434.
9 years ago
chrox 17f1498156 fix successively set landscape rotate the screen 9 years ago
chrox 5d79158602 fix cannot save document if exit directly after highlighting in PDF 9 years ago
chrox f22a53affd screen orientation won't change when going into filemanager
and filemanager remembers screen orientation at exit
This should fix #1338.
9 years ago
Hans-Werner Hilse 7c1c072b21 fix for rotated document to file manager transition: do a refresh
fixes part 2 of #1333
10 years ago
chrox aa9566205b fix filemanager cannot remember sorting order 10 years ago
Frans de Jonge 66f04af8fb Various applications of util.template
This is the first bunch for #1276. I'd like to resolve #1281 before doing more.
10 years ago
Hans-Werner Hilse 22697adf20 switch from scaleByDPI() to scaleBySize() 10 years ago
Frans de Jonge 26baa5e007 Added timeout to successful delete message. 10 years ago
Frans de Jonge 324d67a7a8 Various language-related fixes. 10 years ago
Frans de Jonge 81cb358775 Change rm invocation from rm -r to rm -rf
Fixes #941.
10 years ago
Frans de Jonge 5faff6331f "File to remove" DEBUG message was empty
You can't get the full file path of a file that no longer exists, obviously.
10 years ago
Frans de Jonge 886a9d8f8f File manager improvements: added delete confirmation dialog and success/failure message
This makes deleting files from within KOReader less scary and also provides the initial framework for handling different exit codes for #941.
10 years ago
chrox 7b5358c481 fix filemanager not aware screen dimen when change from landscape to portrait 10 years ago
chrox 461afa25a8 add 'Home' key event to close filemanager 10 years ago