e4319ddaea
[feat, UX] Gesture manager: add support for diagonal swipes ( #4710 )
...
NB The north east and north west arrows are swapped, see https://github.com/koreader/koreader/issues/4707
5 years ago
57ce8dc574
[UX] Gesture manager: add action - show dictionary/Wikipedia ( #4699 )
...
References #4687 .
5 years ago
ab53d798e5
[UX] GestureDetector: add diagonal multiswipes ( #4704 )
...
Multiswipes consisting of mixed straight and diagonal strokes are not dependable and too easy to mess up, but making them mutually exclusive seems to work out quite well.
5 years ago
779909343c
[UX] ButtonProgressWidget: thin grey buttons instead of black ( #4700 )
...
May help with ghosting when closing bottom dialog,
and fit better with the other grey toggles.
5 years ago
9fb7801974
[fix] ConfigMenu cre margins hold action ( #4702 )
...
See https://github.com/koreader/koreader/pull/4691#issuecomment-468905263
5 years ago
503e1a815c
bump base: crengine crash fix, cre footnote popup tweaks ( #4701 )
...
Includes:
- Bump libjpeg-turbo to 2.0.2
- bump crengine: fix crash on CSS "border-width: inherit"
- cre: tweak footnote popup detection
5 years ago
d8845f8589
[fix] GestureDetector: only initiate multiswipe with clear N/S/E/W direction ( #4698 )
...
Accidentally lost while refacturing. See <https://github.com/koreader/koreader/pull/4640#issuecomment-468788986 >.
5 years ago
cfd7fcb357
[CI] Add .codecov.yml ( #4695 )
...
This should hopefully make it stop saying commits "fail" for not reaching 70 % coverage.
5 years ago
3aa5ebb1df
[fix] Gesture manager: most defaults should be reader-only
5 years ago
8a1c0f6bd4
[UX] Gesture manager: add default previous/next chapter gesture
...
* Up, down, up for previous.
* Dow, up, down for next.
5 years ago
ba4bf7243d
[chore] Deprecate TapForward/TapBackward ( #4689 )
...
Also fix previous page action in gesture manager.
5 years ago
87b6217696
[fix, spec] readerrolling_spec: rename onDoubleTapForward/Backward to GotoNextChapter/PrevChapter ( #4693 )
...
See https://github.com/koreader/koreader/pull/4692#issuecomment-468689490
5 years ago
89fe3e3051
[spec] Fix defaults_spec
...
Updated for https://github.com/koreader/koreader/pull/4691
Also the assert.is_same() argument order was wrong.
The first argument is expected, the second the real-life result.
Otherwise the error message in case of failure is misleading.
5 years ago
1d1dc74290
[UX] creoptions: add more margin values
...
Fixes #4684 .
5 years ago
1e4469fec2
[UX] Gesture manager: add actions - prev/next chapter ( #4692 )
...
Also adds rudimentary support for these in ReaderPaging.
5 years ago
1475acdae7
[UX] Gesture manager: add action - go to ( #4690 )
...
Cf. <https://github.com/koreader/koreader/issues/4687 >.
5 years ago
332fa642e3
[UX] Gesture manager: add action - toggle reflow ( #4688 )
...
Cf. https://github.com/koreader/koreader/issues/4687
5 years ago
97c6c1244f
add support for likebook mimas e-ink updates ( #4686 )
5 years ago
4547b2d65f
[fix] GestureDetector: add PAN_DELAYED_INTERVAL ( #4666 )
...
When multiswipes are enabled, this fixes the long-standing complaint that swiping to open the menu could unintentionally trigger some light panning. With the introduction of multiswipes, this problem has become more noticeable.
5 years ago
96823df503
[UX] Navigation settings for all devices ( #4680 )
...
Before multiswipes and the gesture manager this was impractical on touch-only devices, but no more!
Also includes some minor textual clarifications on some of the settings.
5 years ago
060902534d
[fix] Gesture manager: more logical position for file browser ( #4679 )
...
See https://github.com/koreader/koreader/pull/4678#issuecomment-468378040
5 years ago
db0467c9f0
[UX] Introduce Taps & Gestures menu ( #4677 )
...
This more logically groups together various settings related to taps and gestures.
Cf. <https://github.com/koreader/koreader/pull/4655#issuecomment-466808273 >.
5 years ago
32d813dc92
[UX] Gesture manager: add action - go to file browser ( #4678 )
...
Fixes #4676 .
5 years ago
a1f7f25eaf
[chore, UX] Migrate Screen menu to MenuSorter & put Screensaver under Screen ( #4675 )
...
Doing more of this is the general purpose of MenuSorter, after all.
This is making some space for a new `Taps and gestures` menu, see <https://github.com/koreader/koreader/pull/4655#issuecomment-466808273 >.
5 years ago
cd3ca88316
[spec] Even more TimeVal coverage ( #4674 )
5 years ago
75501d5f83
[fix] ReaderGesture: enable/disable multiswipes without restarting ( #4673 )
5 years ago
626d7340f3
[spec] Add more TimeVal tests ( #4672 )
...
That should please CodeCov.
5 years ago
abba7ba873
[fix] TimeVal: add dbg:guard against incorrect subtraction order ( #4669 )
...
In principle, any negative subtraction result should be caused by a logical error.
5 years ago
163853afdf
[UX] Gesture manager: add action - show menu ( #4665 )
5 years ago
1c0a8c1ef9
cre scroll mode: fix last line of book hidden by footer
...
By scrolling last page a little bit further.
Also fix a few other scroll mode issues, all related
to doc_height not being updated (eg, in the middle of
a book, and doubling the font size, one would not
be able to turn pages and read the 2nd half of the
book...)
5 years ago
918f296bd3
cre scroll mode: fix highlights not shown when small pages
...
The idea of looking for highlights 1 page before and after
was not working when you have multiple small pages, and
some scroll mode view was actually showing 3 or 4 pages.
So, rework that by using absolute positions when looking
for highlights present in the scrolled view.
5 years ago
7779f674ee
bump crengine: fix text selection and cache issues
...
Includes:
- Fix text selection in some tables
- Add known HTML attributes to avoid cache issues
- Make existing context.AddLine() and pb_flag clearer
cre.cpp:
- gotoPos(): allow scrolling after end of document
(to avoid not seeing the last line of a document
that would be hidden by the footer bar)
5 years ago
f8f3132315
[UX] Gesture manager: add action - show frontlight dialog ( #4664 )
...
Rationale for the default `down, left` gesture: it's pointing at the location for the frontlight toggle.
5 years ago
6ddba11392
[UX] Alternative update message when ota_version < local_version ( #4661 )
...
See https://github.com/koreader/koreader/issues/4650#issuecomment-466965983 and https://github.com/koreader/koreader/pull/4661#issuecomment-467088984
5 years ago
ff14c7896d
[UX] Gesture manager: add north west = folder up as file manager default ( #4662 )
...
Up, left is also the traditional Opera gesture for parent directory.
5 years ago
47ba296f17
[UX] Gesture manager: more multiswipe defaults ( #4660 )
5 years ago
926150db58
[UX] Gesture manager: add action - go to latest bookmark ( #4657 )
5 years ago
dccebe1fb5
[fix] Gesture manager: send TapForward event for page forward ( #4658 )
...
Otherwise you can get rather unexpected results in paged media and scroll mode.
Workaround suggested by @NiLuJe here: https://github.com/koreader/koreader/pull/4570#discussion_r258693835
5 years ago
7098e6ef35
[fix] Gesture manager: default at the top ( #4656 )
...
Accidentally broken by 1d6948ddf1
5 years ago
1d6948ddf1
[UX] Gesture manager: show selected action in menu ( #4655 )
5 years ago
ab1132e885
[UX] Gesture manager: re-order actions, add Skim option ( #4654 )
...
Also move multiswipes_enabled setting reading into init(),
to avoid it taking effect only after next restart.
5 years ago
91b83c5176
[UX] Gesture manager: delete custom gestures and update menu ( #4652 )
...
Include a safety check to prevent rerecording an existing gesture.
Also extend the default set of gestures to include all of them, and add east south west north for refresh. (I've always thought small diagonal swipe to be rather awkward to trigger.)
See https://github.com/koreader/koreader/pull/4644#issuecomment-466743715 and https://github.com/koreader/koreader/issues/4651 regarding the menu update.
5 years ago
d090f3e651
[fix, UX] GestureDetector: fix multiswipe length detection ( #4649 )
...
Reported by @poire-z, cf. https://github.com/koreader/koreader/pull/4640#issuecomment-466544922
Apparently it's natural for me to make the second swipe slightly longer than the first, so I never noticed a logic issue. I did notice that it seemed slightly harder to make 4-swipe multiswipes than I expected it to be, but those are not necessarily easy gestures to make.
The problem was that I needed to prevent obviously silly gestures like west west west east. In ignoring such duplication, what I accidentally did was to ignore any further movement west after the first multiswipe direction was detected, meaning that the following swipe east could still end up as a relatively western movement overall.
By simply updating the current multiswipe slot in case of the same direction, both problems are prevented. We'll never get the same direction twice, and X moves over to where it's supposed to be on the left.
5 years ago
0532d7a507
[Android] (re)enable update downloads using full apks ( #4639 )
5 years ago
76028513ea
[Android] Bump luajit-launcher for basic download & notification support ( #4647 )
...
https://github.com/koreader/android-luajit-launcher/pull/122
For https://github.com/koreader/koreader/pull/4639
5 years ago
92174815a8
[fix] ReaderGesture: don't crash without custom gestures ( #4645 )
...
Silly oversight in https://github.com/koreader/koreader/pull/4644 .
Also remove unused util because apparently CircleCI didn't run on the other PR when it should've.
5 years ago
2e255a1abd
[feat, UX] Add multiswipe recorder ( #4644 )
5 years ago
6246d44068
[fix] Gesture manager: actually register multiswipe ( #4643 )
...
Accidentally broken in https://github.com/koreader/koreader/pull/4623
Also see https://github.com/koreader/koreader/pull/4640#issuecomment-466443328
5 years ago
9a92792551
[feat, UX] Gesture manager: add option - open previous document ( #4641 )
...
Fixes #4333 .
5 years ago
260427d226
[fix] GestureDetector: fix multiswipe direction detection code ( #4640 )
...
Unfortunately a mistake snuck into the final steps of refactoring <https://github.com/koreader/koreader/pull/4607 >.
Thanks to @poire-z for pointing it out [here](https://github.com/koreader/koreader/pull/4607#issuecomment-464856789 ).
5 years ago
Frans de Jonge
poire-z
Martín Fernández