mirror of https://github.com/koreader/koreader
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
fadee1f5dc
Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups. |
2 years ago | |
|---|---|---|
| .. | ||
| container | 2 years ago | |
| bboxwidget.lua | 2 years ago | |
| bookmapwidget.lua | 2 years ago | |
| bookstatuswidget.lua | 2 years ago | |
| button.lua | 2 years ago | |
| buttondialog.lua | 2 years ago | |
| buttondialogtitle.lua | 2 years ago | |
| buttonprogresswidget.lua | 2 years ago | |
| buttontable.lua | 2 years ago | |
| checkbutton.lua | 2 years ago | |
| checkmark.lua | 2 years ago | |
| closebutton.lua | 2 years ago | |
| configdialog.lua | 2 years ago | |
| confirmbox.lua | 2 years ago | |
| datetimewidget.lua | 2 years ago | |
| dictquicklookup.lua | 2 years ago | |
| doublespinwidget.lua | 2 years ago | |
| eventlistener.lua | 2 years ago | |
| filechooser.lua | 2 years ago | |
| fixedtextwidget.lua | 2 years ago | |
| focusmanager.lua | 2 years ago | |
| footnotewidget.lua | 2 years ago | |
| frontlightwidget.lua | 2 years ago | |
| horizontalgroup.lua | 2 years ago | |
| horizontalscrollbar.lua | 2 years ago | |
| horizontalspan.lua | 2 years ago | |
| htmlboxwidget.lua | 2 years ago | |
| iconbutton.lua | 2 years ago | |
| iconwidget.lua | 2 years ago | |
| imageviewer.lua | 2 years ago | |
| imagewidget.lua | 2 years ago | |
| infomessage.lua | 2 years ago | |
| inputdialog.lua | 2 years ago | |
| inputtext.lua | 2 years ago | |
| keyboardlayoutdialog.lua | 2 years ago | |
| keyvaluepage.lua | 2 years ago | |
| linewidget.lua | 2 years ago | |
| linkbox.lua | 2 years ago | |
| listview.lua | 2 years ago | |
| logindialog.lua | 2 years ago | |
| menu.lua | 2 years ago | |
| multiconfirmbox.lua | 2 years ago | |
| multiinputdialog.lua | 2 years ago | |
| naturallightwidget.lua | 2 years ago | |
| networksetting.lua | 2 years ago | |
| notification.lua | 2 years ago | |
| numberpickerwidget.lua | 2 years ago | |
| openwithdialog.lua | 2 years ago | |
| overlapgroup.lua | 2 years ago | |
| pagebrowserwidget.lua | 2 years ago | |
| pathchooser.lua | 2 years ago | |
| physicalkeyboard.lua | 2 years ago | |
| progresswidget.lua | 2 years ago | |
| qrmessage.lua | 2 years ago | |
| qrwidget.lua | 4 years ago | |
| radiobutton.lua | 2 years ago | |
| radiobuttontable.lua | 2 years ago | |
| radiobuttonwidget.lua | 2 years ago | |
| radiomark.lua | 2 years ago | |
| rectspan.lua | 2 years ago | |
| screensaverwidget.lua | 2 years ago | |
| screenshoter.lua | 2 years ago | |
| scrollhtmlwidget.lua | 2 years ago | |
| scrolltextwidget.lua | 2 years ago | |
| skimtowidget.lua | 2 years ago | |
| sortwidget.lua | 2 years ago | |
| spinwidget.lua | 2 years ago | |
| textboxwidget.lua | 2 years ago | |
| textviewer.lua | 2 years ago | |
| textwidget.lua | 2 years ago | |
| titlebar.lua | 2 years ago | |
| toggleswitch.lua | 2 years ago | |
| touchmenu.lua | 2 years ago | |
| trapwidget.lua | 2 years ago | |
| verticalgroup.lua | 2 years ago | |
| verticalscrollbar.lua | 2 years ago | |
| verticalspan.lua | 2 years ago | |
| virtualkeyboard.lua | 2 years ago | |
| widget.lua | 2 years ago | |