Silence various warnings

llarp/config/config.cpp

@@ -166,12 +166,12 @@ namespace llarp
     conf.defineOption<bool>(
         "network", "reachable", false, ReachableDefault, AssignmentAcceptor(m_reachable));
 
-    conf.defineOption<int>("network", "hops", false, HopsDefault, [this](int arg) {
+    conf.defineOption<int>("network", "hops", false, HopsDefault, [](int arg) {
       if (arg < 1 or arg > 8)
         throw std::invalid_argument("[endpoint]:hops must be >= 1 and <= 8");
     });
 
-    conf.defineOption<int>("network", "paths", false, PathsDefault, [this](int arg) {
+    conf.defineOption<int>("network", "paths", false, PathsDefault, [](int arg) {
       if (arg < 1 or arg > 8)
         throw std::invalid_argument("[endpoint]:paths must be >= 1 and <= 8");
     });

llarp/dht/context.cpp

@@ -141,7 +141,7 @@ namespace llarp
           uint64_t txid,
           const service::EncryptedIntroSet& introset,
           const Key_t& tellpeer,
-          uint64_t relayOrder);
+          uint64_t relayOrder) override;
 
       /// send introset to peer from source with S counter and excluding peers
       void
@@ -150,7 +150,7 @@ namespace llarp
           uint64_t txid,
           const service::EncryptedIntroSet& introset,
           const Key_t& tellpeer,
-          uint64_t relayOrder);
+          uint64_t relayOrder) override;
 
       /// initialize dht context and explore every exploreInterval milliseconds
       void

llarp/net/exit_info.cpp

@@ -92,7 +92,8 @@ namespace llarp
   }
 
   std::ostream&
-  ExitInfo::print(std::ostream& stream, int level, int spaces) const
+  ExitInfo::print(
+      std::ostream& stream, [[maybe_unused]] int level, [[maybe_unused]] int spaces) const
   {
     /*
     // TODO: derive these from ipAdress

llarp/rpc/rpc.cpp

@@ -258,7 +258,7 @@ namespace llarp
         handler({}, false);
         return false;
       }
-      for (const auto item : itr.value())
+      for (const auto& item : itr.value())
       {
         if (not item.is_object())
           continue;

llarp/service/endpoint.cpp

@@ -43,7 +43,7 @@ namespace llarp
     }
 
     bool
-    Endpoint::Configure(const NetworkConfig& conf, const DnsConfig& dnsConf)
+    Endpoint::Configure(const NetworkConfig& conf, [[maybe_unused]] const DnsConfig& dnsConf)
     {
       if (conf.m_paths > 0)
         numPaths = conf.m_paths;

llarp/service/endpoint.hpp

@@ -256,7 +256,7 @@ namespace llarp
       MarkAddressOutbound(const Address&) override;
 
       bool
-      ShouldBundleRC() const
+      ShouldBundleRC() const override
       {
         return false;
       }

test/test_libabyss.cpp

@@ -116,7 +116,7 @@ struct ServerHandler : public abyss::httpd::IRPCHandler
   }
 
   Response
-  HandleJSONRPC(Method_t method, const Params& /*params*/)
+  HandleJSONRPC(Method_t method, const Params& /*params*/) override
   {
     test->AssertMethod(method);
     test->called = true;

test/util/thread/test_llarp_util_queue_manager.cpp

@@ -89,7 +89,7 @@ class IntQueue
     }
     else
     {
-      return {};
+      return std::nullopt;
     }
   }