Commit Graph

572 Commits (master)

Author SHA1 Message Date
Mariano Cano fd4e96d1f4 Rename method to IsChallengeEnabled 2 years ago
Mariano Cano c77b4ff9c5 Fix linter errors 2 years ago
Mariano Cano 59c5219a07 Use a type for acme challenges 2 years ago
Raal Goff b89f210469 remove fail-email test and add ok-empty-email test 2 years ago
Raal Goff 7a03c43fe2 allow missing Email claim in OIDC tokens, use subject when its missing 2 years ago
Mariano Cano df96b126dc Add AuthorizeChallenge unit tests 2 years ago
Mariano Cano bca311b05e Add acme property to enable challenges
Fixes #1027
2 years ago
Mariano Cano 693dc39481 Merge branch 'master' into device-attestation 2 years ago
Mariano Cano 23b8f45b37 Address gosec warnings
Most if not all false positives
2 years ago
Mariano Cano 5df1694250 Add endpoint id for the RA certificate
In a linked RA mode, send an endpoint id to group the server
certificates.
2 years ago
Mariano Cano 21427d5d65 Replace instead of prepend provisioner extension
With non standard SANs this will generate the SAN and provisioner
extension in the same order.
2 years ago
Mariano Cano 6b5d3dca95 Add provisioner name to RA info 2 years ago
Mariano Cano a1f54921d2 Rename internal field 2 years ago
Mariano Cano 9408d0f24b Send RA provisioner information to the CA 2 years ago
Shulhan fe04f93d7f
all: reformat all go files with the next gofmt (Go 1.19)
There are some changes that manually edited, for example using '-' as
default list and grouping imports.
2 years ago
Mariano Cano 6b3a8f22f3 Add provisioner to SSH renewals
This commit allows to report the provisioner to the linkedca when
a SSH certificate is renewed.
2 years ago
Mariano Cano 3c4d0412ef
Merge pull request #941 from smallstep/ssh-provisioner
Report SSH provisioner
2 years ago
Mariano Cano a627f21440 Fix AuthorizeSSHSign tests with extra SignOption 2 years ago
Mariano Cano e7d7eb1a94 Add provisioner as a signOption for SSH 2 years ago
Herman Slatman 479eda7339
Improve error message when client renews with expired certificate
When a client provides an expired certificate and `AllowAfterExpiry`
is not enabled, the client would get a rather generic error with
instructions to view the CA logs. Viewing the CA logs can be done
when running `step-ca`, but they can't be accessed easily in the
hosted solution.

This commit returns a slightly more informational message to the
client in this specific situation.
2 years ago
Herman Slatman 5e9bce508d
Unexport GetPolicy() 2 years ago
Herman Slatman d82e51b748
Update AllowWildcardNames configuration name 2 years ago
Herman Slatman 2b7f6931f3
Change Subject Common Name verification
Subject Common Names can now also be configured to be allowed or
denied, similar to SANs. When a Subject Common Name is not explicitly
allowed or denied, its type will be determined and its value will be
validated according to the constraints for that type of name (i.e. URI).
2 years ago
Herman Slatman 6e1f8dd7ab
Refactor policy engines into container 2 years ago
Herman Slatman 2a7620641f
Fix more PR comments 2 years ago
Herman Slatman c40a4d2694
Contain policy engines inside provisioner Controller 2 years ago
Herman Slatman 72bbe53376
Add additional policy options 2 years ago
Herman Slatman 7f9034d22a
Add additional policy options 2 years ago
Herman Slatman abcad679ff
Merge branch 'master' into herman/allow-deny 2 years ago
Herman Slatman d6be9450be
Merge branch 'master' into herman/allow-deny 2 years ago
Mariano Cano d3b6bc3c75 Merge branch 'master' into fix/adminra 2 years ago
Mariano Cano 674dc3c844 Rename unreleased claim to allowRenewalAfterExpiry for consistency. 2 years ago
Herman Slatman 0bb15e16f9
Fix missing ACME provisioner option 2 years ago
Herman Slatman 9797b3350e
Merge branch 'master' into herman/allow-deny 2 years ago
Mariano Cano 8abd568f03 Merge branch 'master' into fix/adminra 2 years ago
Mariano Cano b7e11da480 Merge branch 'master' into feat/linkedra 2 years ago
Mariano Cano df8ffb35af Remove unnecessary database in provisioner config. 2 years ago
Herman Slatman d8776d8f7f
Add K8sSA SSH user policy back
According to the docs, the K8sSA provisioner can be configured
to issue SSH user certs.
2 years ago
Herman Slatman 571b21abbc
Fix (most) PR comments 2 years ago
Herman Slatman 628d7448de
Don't return policy in provisioner JSON 2 years ago
Herman Slatman 2fbdf7d5b0
Merge branch 'master' into herman/allow-deny 2 years ago
Panagiotis Siatras 00634fb648
api/render, api/log: initial implementation of the packages (#860)
* api/render: initial implementation of the package

* acme/api: refactored to support api/render

* authority/admin: refactored to support api/render

* ca: refactored to support api/render

* api: refactored to support api/render

* api/render: implemented Error

* api: refactored to support api/render.Error

* acme/api: refactored to support api/render.Error

* authority/admin: refactored to support api/render.Error

* ca: refactored to support api/render.Error

* ca: fixed broken tests

* api/render, api/log: moved error logging to this package

* acme: refactored Error so that it implements render.RenderableError

* authority/admin: refactored Error so that it implements render.RenderableError

* api/render: implemented RenderableError

* api/render: added test coverage for Error

* api/render: implemented statusCodeFromError

* api: refactored RootsPEM to work with render.Error

* acme, authority/admin: fixed pointer receiver name for consistency

* api/render, errs: moved StatusCoder & StackTracer to the render package
2 years ago
Mariano Cano 6851842841 Fix unit tests. 2 years ago
vijayjt 37207793f9 Pass in the resource name regardless of if its a VM or managed identity 2 years ago
vijayjt 7e47c70af2 Remove redundant parameter type declaration 2 years ago
vijayjt 7b605b2d16 Support Azure tokens from managed identities not associated with a VM 2 years ago
Mariano Cano 5ab79f53be Fix linter errors 2 years ago
Herman Slatman b49307f326
Fix ACME order tests with mock ACME CA 2 years ago
Herman Slatman 9e0edc7b50
Add early authority policy evaluation to ACME order API 2 years ago
Herman Slatman 613c99f00f
Fix linting issues 2 years ago
Herman Slatman dc23fd23bf
Merge branch 'master' into herman/allow-deny-next 2 years ago
Mariano Cano 082734474b
Merge pull request #845 from vijayjt/azure-user-mi-token
WIP: Support Azure tokens generated by managed identities
2 years ago
Mariano Cano b401376829 Add current provisioner to AuthorizeSign SignOptions.
The original provisioner cannot be retrieved from a certificate
if a linked ra is used.
2 years ago
vijayjt 24a963766e Pass in the resource name regardless of if its a VM or managed identity 2 years ago
Mariano Cano ad8a813abe Fix linter errors 2 years ago
Mariano Cano 6d532045dc Fix validity check for sshpop provisioner. 2 years ago
Mariano Cano c903f00cd4 Rename claim to allowRenewAfterExpiry. 2 years ago
Mariano Cano 4690fa64ed Add public methods to retrieve the provisioner extensions. 2 years ago
Mariano Cano 616490a9c6 Refactor renew after expiry token authorization
This changes adds a new authority method that authorizes the
renew after expiry tokens.
2 years ago
Mariano Cano 389815642d Fix tests: certs are truncated to seconds. 2 years ago
Mariano Cano 8ef8f4f665 Use the provisioner controller in Nebula renewals 2 years ago
Mariano Cano 259e95947c Add support for the provisioner controller
The claimer, audiences and custom callback methods are now managed
by the provisioner controller in an uniform way.
2 years ago
Mariano Cano 3c2ff33ca9 Add provisioner controller tests. 2 years ago
Mariano Cano fd6a2eeb9c Add provisioner controller
The provisioner controller has the implementation of the identity
function as well as the renew methods with renew after expiry
support.
2 years ago
Herman Slatman 3ec9a7310c
Fix ACME order identifier allow/deny check 2 years ago
Herman Slatman 7c541888ad
Refactor configuration of allow/deny on authority level 2 years ago
Herman Slatman af53a17bb4
Merge branch 'master' into herman/allow-deny 2 years ago
vijayjt 4822516d72 Remove redundant parameter type declaration 2 years ago
vijayjt e699244291 Support Azure tokens from managed identities not associated with a VM 2 years ago
Mariano Cano 15b1049f19 Fix json tag for Azure.ObjectIDs. 2 years ago
vijayjt 4a10f2c584 Rename new fields as per feedback to remove AAD from the name 2 years ago
vijayjt 8b68bedffa Add support for validation of certificate requests using Azure subscription and AAD object IDs. See #735 2 years ago
Herman Slatman c3c6f3da72
Merge branch 'master' into herman/allow-deny 2 years ago
Mariano Cano abe951d416 Fix name of the variable in comment. 2 years ago
Mariano Cano a0cf808393 Make the X5C leaf certificate available to the templates.
X509 and SSH templates of the X5C provisioner will have now access
to the leaf certificate used to sign the token using the template
variable .AuthorizationCrt

Fixes #433
2 years ago
Herman Slatman 88c7b63c9d
Split SSH user and cert policy configuration and execution 2 years ago
Herman Slatman acd13cb92d
Merge branch 'master' of github.com:smallstep/certificates into herman/allow-deny 2 years ago
Herman Slatman c1424036bf
Merge branch 'master' into herman/allow-deny 2 years ago
Herman Slatman c7c5c3c94e
Merge branch 'master' into herman/scep-macos-renewal-fixes 2 years ago
Herman Slatman 9617edf0c2
Improve internationalized domain name handling
This PR improves internationalized domain name handling according
to rules of IDNA and based on the description in RFC 5280, section 7:
https://datatracker.ietf.org/doc/html/rfc5280#section-7.

Support for internationalized URI(s), so-called IRIs, still needs to
be done.
2 years ago
Herman Slatman 512b8d6730
Refactor instantiation of policy engines
Instead of using the `base` struct, the x509 and SSH policy
engines are now added to each provisioner directly.
2 years ago
Herman Slatman 066bf32086
Fix part of PR comments 2 years ago
Herman Slatman 8838961b68
Merge branch 'master' into hs/acme-eab 2 years ago
Herman Slatman 64680bb16d
Fix PR comments 2 years ago
Herman Slatman 3612eefc31
Cleanup 2 years ago
Herman Slatman 6440870a80
Clean up, improve test cases and coverage 2 years ago
Herman Slatman 1e808b61e5
Merge logic for X509 and SSH policy 2 years ago
Herman Slatman 6bc301339f
Improve test case and code coverage 2 years ago
Herman Slatman 91d51c2b88
Add allow/deny to Nebula provisioner 2 years ago
Herman Slatman d9c56d67cc
Merge branch 'master' into herman/allow-deny 2 years ago
Herman Slatman 9c6580ccd2
Fix macOS SCEP client issues
Fixes #746
2 years ago
Mariano Cano 0920224816 Fix error message. 2 years ago
Mariano Cano 449a9fdfd6 Address review comments. 2 years ago
Mariano Cano b424aa3dc1 Add nebula header and use der version of certificate. 2 years ago
Mariano Cano f49a4b326f Add missing comments. 2 years ago
Mariano Cano 6600f1253e Fix error messages after review. 2 years ago
Mariano Cano de51c2edfb More unit tests for nebula. 2 years ago
Mariano Cano 99845d38bb Add some extra unit tests for nebula. 2 years ago
Mariano Cano 76794ce613 Use default SANs without sans in the token.
Fix step claim condition in SSH
2 years ago
Herman Slatman 6bc0513468
Add more tests 2 years ago
Mariano Cano 9ec0276887 Update certificate set with new api. 2 years ago
Herman Slatman 9539729bd9
Add initial implementation of x509 and SSH allow/deny policy engine 2 years ago
Mariano Cano cb72796a2d Fix decoding of certificate. 2 years ago
Mariano Cano 32390a2964 Add initial implementation of a nebula provisioner.
A nebula provisioner will generate a X509 or SSH certificate with
the identities in the nebula certificate embedded in the token.
The token is signed with the private key of the nebula certificate.
2 years ago
Herman Slatman d799359917
Merge branch 'master' into hs/acme-eab 3 years ago
Herman Slatman 3bc3957b06
Merge branch 'master' into hs/acme-revocation 3 years ago
Herman Slatman d0c23973cc
Merge branch 'master' into hs/acme-eab 3 years ago
Mariano Cano e0fee84694 Add comment about public key validator. 3 years ago
Herman Slatman a7fbbc4748
Add tests for GetCertificateBySerial 3 years ago
Herman Slatman c9cd876a7d
Merge branch 'master' into hs/acme-revocation 3 years ago
Mariano Cano c3f98fd04d Change some bad requests to forbidded.
Change in the sign options bad requests to forbidded if is the
provisioner the one adding a restriction, e.g. list of dns names,
validity, ...
3 years ago
Mariano Cano b9beab071d Fix unit tests. 3 years ago
Mariano Cano 507a272b4d Return always http errors in sign options. 3 years ago
Mariano Cano a33709ce8d Fix sign ssh options tests. 3 years ago
Mariano Cano 1da7ea6646 Return always http errors in sign ssh options. 3 years ago
Herman Slatman 2d50c96d99
Merge branch 'master' into hs/acme-revocation 3 years ago
Mariano Cano b6ebd118fc Update temporal solution for sending message to users 3 years ago
Mariano Cano 668d3ea6c7 Modify errs.Wrap() with bad request to send messages to users. 3 years ago
Mariano Cano 8c8db0d4b7 Modify errs.BadRequestErr() to always return an error to the client. 3 years ago
Mariano Cano 8ce807a6cb Modify errs.BadRequest() calls to always send an error to the client. 3 years ago
Mariano Cano 440616cffa
Merge pull request #750 from smallstep/duration-errors
Report duration errors directly to the cli.
3 years ago
Mariano Cano acd0bac025 Remove extra and in comment. 3 years ago
Mariano Cano 1aadd63cef Use always badRequest on duration errors. 3 years ago
Mariano Cano 41fec1577d Report duration errors directly to the cli. 3 years ago
Herman Slatman e7a988b2cd
Pin golangci-lint to v1.43.0 and fix issues 3 years ago
Herman Slatman 3151255a25
Merge branch 'master' into hs/acme-revocation 3 years ago
Herman Slatman e0b495e4c8
Merge branch 'master' into hs/acme-eab 3 years ago
max furman 933b40a02a Introduce gocritic linter and address warnings 3 years ago
Herman Slatman 9d4cafc4bd
Merge branch 'master' into hs/acme-eab 3 years ago
Mariano Cano a50654b468 Check for admins in both emails and groups. 3 years ago
Herman Slatman 66464ae302
Merge branch 'master' into hs/acme-eab 3 years ago
Mariano Cano 141c519171 Simplify check of principals in a case insensitive way
Fixes #679
3 years ago
Fearghal O Floinn 7a94b0c157 Converts group and subgroup to lowercase for comparison.
Fixes #679
3 years ago
Mariano Cano f919535475 Add an extra way to distinguish Azure and Azure OIDC tokens.
We used to distinguish these tokens using the azp claim, but this
claim does not appear on new azure oidc tokens, at least on some
configurations.

This change will try to load by audience (client id) if the token
contains an email, required for OIDC.
3 years ago
Herman Slatman a98fe03e80
Merge branch 'master' into hs/acme-eab 3 years ago
Mariano Cano 40e77f6e9a Initialize required variables on GetIdentityToken
Fixes smallstep/cli#465
3 years ago
Mariano Cano 42fde8ba28
Merge branch 'master' into linkedca 3 years ago
Mariano Cano d4ae267add Fix ErrAllowTokenReuse comment. 3 years ago
Mariano Cano 9e5762fe06 Allow the reuse of azure token if DisableTrustOnFirstUse is true
Azure caches tokens for 24h and we cannot issue a new certificate
for the same instance in that period of time.

The meaning of this parameter is to allow the signing of multiple
certificate in one instance. This is possible in GCP, because we
get a new token, and is possible in AWS because we can generate
a new one. On Azure there was no other way to do it unless you
wait for 24h.

Fixes #656
3 years ago
Herman Slatman f31ca4f6a4
Add tests for validateExternalAccountBinding 3 years ago
Mariano Cano f7542a5bd9 Move check of ssh revocation from provisioner to the authority. 3 years ago
Herman Slatman f81d49d963
Add first working version of External Account Binding 3 years ago
Herman Slatman 258efca0fa
Improve revocation authorization 3 years ago
max furman 77fdfc9fa3 Merge branch 'master' into max/cert-mgr-crud 3 years ago
max furman 9fdef64709 Admin level API for provisioner mgmt v1 3 years ago
Herman Slatman a64974c179 Fix small typo in divisible 3 years ago
Herman Slatman d46a4eaca4 Change fmt to errors package for formatting errors 3 years ago
Herman Slatman 2beea1aa89 Add configuration option for specifying the minimum public key length
Instead of using the defaultPublicKeyValidator a new validator called
publicKeyMinimumLengthValidator has been implemented that uses a
configurable minimum length for public keys in CSRs.

It's also an option to alter the defaultPublicKeyValidator to also
take a parameter, but that would touch quite some lines of code. This
might be a viable option after merging SCEP support.
3 years ago
Herman Slatman 4168449935 Fix typo 3 years ago
Herman Slatman fa100a5138 Mask challenge password after it has been read 3 years ago