dc23fd23bf
Merge branch 'master' into herman/allow-deny-next
2 years ago
082734474b
Merge pull request #845 from vijayjt/azure-user-mi-token
...
WIP: Support Azure tokens generated by managed identities
2 years ago
b401376829
Add current provisioner to AuthorizeSign SignOptions.
...
The original provisioner cannot be retrieved from a certificate
if a linked ra is used.
2 years ago
24a963766e
Pass in the resource name regardless of if its a VM or managed identity
2 years ago
ad8a813abe
Fix linter errors
2 years ago
6d532045dc
Fix validity check for sshpop provisioner.
2 years ago
c903f00cd4
Rename claim to allowRenewAfterExpiry.
2 years ago
4690fa64ed
Add public methods to retrieve the provisioner extensions.
2 years ago
616490a9c6
Refactor renew after expiry token authorization
...
This changes adds a new authority method that authorizes the
renew after expiry tokens.
2 years ago
389815642d
Fix tests: certs are truncated to seconds.
2 years ago
8ef8f4f665
Use the provisioner controller in Nebula renewals
2 years ago
259e95947c
Add support for the provisioner controller
...
The claimer, audiences and custom callback methods are now managed
by the provisioner controller in an uniform way.
2 years ago
3c2ff33ca9
Add provisioner controller tests.
2 years ago
fd6a2eeb9c
Add provisioner controller
...
The provisioner controller has the implementation of the identity
function as well as the renew methods with renew after expiry
support.
2 years ago
3ec9a7310c
Fix ACME order identifier allow/deny check
2 years ago
7c541888ad
Refactor configuration of allow/deny on authority level
2 years ago
af53a17bb4
Merge branch 'master' into herman/allow-deny
2 years ago
4822516d72
Remove redundant parameter type declaration
2 years ago
e699244291
Support Azure tokens from managed identities not associated with a VM
2 years ago
15b1049f19
Fix json tag for Azure.ObjectIDs.
2 years ago
4a10f2c584
Rename new fields as per feedback to remove AAD from the name
2 years ago
8b68bedffa
Add support for validation of certificate requests using Azure subscription and AAD object IDs. See #735
2 years ago
c3c6f3da72
Merge branch 'master' into herman/allow-deny
2 years ago
abe951d416
Fix name of the variable in comment.
2 years ago
a0cf808393
Make the X5C leaf certificate available to the templates.
...
X509 and SSH templates of the X5C provisioner will have now access
to the leaf certificate used to sign the token using the template
variable .AuthorizationCrt
Fixes #433
2 years ago
88c7b63c9d
Split SSH user and cert policy configuration and execution
2 years ago
acd13cb92d
Merge branch 'master' of github.com:smallstep/certificates into herman/allow-deny
2 years ago
c1424036bf
Merge branch 'master' into herman/allow-deny
2 years ago
c7c5c3c94e
Merge branch 'master' into herman/scep-macos-renewal-fixes
2 years ago
9617edf0c2
Improve internationalized domain name handling
...
This PR improves internationalized domain name handling according
to rules of IDNA and based on the description in RFC 5280, section 7:
https://datatracker.ietf.org/doc/html/rfc5280#section-7 .
Support for internationalized URI(s), so-called IRIs, still needs to
be done.
2 years ago
512b8d6730
Refactor instantiation of policy engines
...
Instead of using the `base` struct, the x509 and SSH policy
engines are now added to each provisioner directly.
2 years ago
066bf32086
Fix part of PR comments
2 years ago
8838961b68
Merge branch 'master' into hs/acme-eab
2 years ago
64680bb16d
Fix PR comments
2 years ago
3612eefc31
Cleanup
2 years ago
6440870a80
Clean up, improve test cases and coverage
2 years ago
1e808b61e5
Merge logic for X509 and SSH policy
2 years ago
6bc301339f
Improve test case and code coverage
2 years ago
91d51c2b88
Add allow/deny to Nebula provisioner
2 years ago
d9c56d67cc
Merge branch 'master' into herman/allow-deny
2 years ago
9c6580ccd2
Fix macOS SCEP client issues
...
Fixes #746
2 years ago
0920224816
Fix error message.
2 years ago
449a9fdfd6
Address review comments.
2 years ago
b424aa3dc1
Add nebula header and use der version of certificate.
2 years ago
f49a4b326f
Add missing comments.
2 years ago
6600f1253e
Fix error messages after review.
2 years ago
de51c2edfb
More unit tests for nebula.
2 years ago
99845d38bb
Add some extra unit tests for nebula.
2 years ago
76794ce613
Use default SANs without sans in the token.
...
Fix step claim condition in SSH
2 years ago
6bc0513468
Add more tests
2 years ago
9ec0276887
Update certificate set with new api.
2 years ago
9539729bd9
Add initial implementation of x509 and SSH allow/deny policy engine
2 years ago
cb72796a2d
Fix decoding of certificate.
2 years ago
32390a2964
Add initial implementation of a nebula provisioner.
...
A nebula provisioner will generate a X509 or SSH certificate with
the identities in the nebula certificate embedded in the token.
The token is signed with the private key of the nebula certificate.
2 years ago
d799359917
Merge branch 'master' into hs/acme-eab
3 years ago
3bc3957b06
Merge branch 'master' into hs/acme-revocation
3 years ago
d0c23973cc
Merge branch 'master' into hs/acme-eab
3 years ago
e0fee84694
Add comment about public key validator.
3 years ago
a7fbbc4748
Add tests for GetCertificateBySerial
3 years ago
c9cd876a7d
Merge branch 'master' into hs/acme-revocation
3 years ago
c3f98fd04d
Change some bad requests to forbidded.
...
Change in the sign options bad requests to forbidded if is the
provisioner the one adding a restriction, e.g. list of dns names,
validity, ...
3 years ago
b9beab071d
Fix unit tests.
3 years ago
507a272b4d
Return always http errors in sign options.
3 years ago
a33709ce8d
Fix sign ssh options tests.
3 years ago
1da7ea6646
Return always http errors in sign ssh options.
3 years ago
2d50c96d99
Merge branch 'master' into hs/acme-revocation
3 years ago
b6ebd118fc
Update temporal solution for sending message to users
3 years ago
668d3ea6c7
Modify errs.Wrap() with bad request to send messages to users.
3 years ago
8c8db0d4b7
Modify errs.BadRequestErr() to always return an error to the client.
3 years ago
8ce807a6cb
Modify errs.BadRequest() calls to always send an error to the client.
3 years ago
440616cffa
Merge pull request #750 from smallstep/duration-errors
...
Report duration errors directly to the cli.
3 years ago
acd0bac025
Remove extra and in comment.
3 years ago
1aadd63cef
Use always badRequest on duration errors.
3 years ago
41fec1577d
Report duration errors directly to the cli.
3 years ago
e7a988b2cd
Pin golangci-lint to v1.43.0 and fix issues
3 years ago
3151255a25
Merge branch 'master' into hs/acme-revocation
3 years ago
e0b495e4c8
Merge branch 'master' into hs/acme-eab
3 years ago
933b40a02a
Introduce gocritic linter and address warnings
3 years ago
9d4cafc4bd
Merge branch 'master' into hs/acme-eab
3 years ago
a50654b468
Check for admins in both emails and groups.
3 years ago
66464ae302
Merge branch 'master' into hs/acme-eab
3 years ago
141c519171
Simplify check of principals in a case insensitive way
...
Fixes #679
3 years ago
7a94b0c157
Converts group and subgroup to lowercase for comparison.
...
Fixes #679
3 years ago
f919535475
Add an extra way to distinguish Azure and Azure OIDC tokens.
...
We used to distinguish these tokens using the azp claim, but this
claim does not appear on new azure oidc tokens, at least on some
configurations.
This change will try to load by audience (client id) if the token
contains an email, required for OIDC.
3 years ago
a98fe03e80
Merge branch 'master' into hs/acme-eab
3 years ago
40e77f6e9a
Initialize required variables on GetIdentityToken
...
Fixes smallstep/cli#465
3 years ago
42fde8ba28
Merge branch 'master' into linkedca
3 years ago
d4ae267add
Fix ErrAllowTokenReuse comment.
3 years ago
9e5762fe06
Allow the reuse of azure token if DisableTrustOnFirstUse is true
...
Azure caches tokens for 24h and we cannot issue a new certificate
for the same instance in that period of time.
The meaning of this parameter is to allow the signing of multiple
certificate in one instance. This is possible in GCP, because we
get a new token, and is possible in AWS because we can generate
a new one. On Azure there was no other way to do it unless you
wait for 24h.
Fixes #656
3 years ago
f31ca4f6a4
Add tests for validateExternalAccountBinding
3 years ago
f7542a5bd9
Move check of ssh revocation from provisioner to the authority.
3 years ago
f81d49d963
Add first working version of External Account Binding
3 years ago
258efca0fa
Improve revocation authorization
3 years ago
77fdfc9fa3
Merge branch 'master' into max/cert-mgr-crud
3 years ago
9fdef64709
Admin level API for provisioner mgmt v1
3 years ago
a64974c179
Fix small typo in divisible
3 years ago
d46a4eaca4
Change fmt to errors package for formatting errors
3 years ago
2beea1aa89
Add configuration option for specifying the minimum public key length
...
Instead of using the defaultPublicKeyValidator a new validator called
publicKeyMinimumLengthValidator has been implemented that uses a
configurable minimum length for public keys in CSRs.
It's also an option to alter the defaultPublicKeyValidator to also
take a parameter, but that would touch quite some lines of code. This
might be a viable option after merging SCEP support.
3 years ago
4168449935
Fix typo
3 years ago
fa100a5138
Mask challenge password after it has been read
3 years ago
97b88c4d58
Address (most) PR comments
3 years ago
4fe7179b95
Add support for configuring capabilities (cacaps)
3 years ago
3b86550dbf
Add support for challenge password
3 years ago
da65f46d0f
Add AuthorizeSign method to SCEP authority
3 years ago
2a249d20de
Refactor initialization of SCEP authority
3 years ago
339039768c
Refactor SCEP authority initialization and clean some code
3 years ago
48c86716a0
Add rudimentary (and incomplete) support for SCEP
3 years ago
638766c615
wip
3 years ago
4f3e5ef64d
wip
3 years ago
5d09d04d14
wip
3 years ago
7b5d6968a5
first commit
3 years ago
a3ec890e71
Fix small typo in divisible
3 years ago
d0a9cbc797
Change fmt to errors package for formatting errors
3 years ago
ff1b46c95d
Add configuration option for specifying the minimum public key length
...
Instead of using the defaultPublicKeyValidator a new validator called
publicKeyMinimumLengthValidator has been implemented that uses a
configurable minimum length for public keys in CSRs.
It's also an option to alter the defaultPublicKeyValidator to also
take a parameter, but that would touch quite some lines of code. This
might be a viable option after merging SCEP support.
3 years ago
c04f556dc2
Merge branch 'master' into hs/scep
3 years ago
d7eec869c2
Fix the previous tests
3 years ago
c2d30f7260
gofmt everything
3 years ago
f38a72a62b
Leftover from previous commit
3 years ago
1d2445e1d8
Removed the variadic username
...
Could be useful later on, but for the current PR changes should be minimized
3 years ago
9e00b82bdf
Revert `oidc_test.go`
...
Moving the `preferred_username` to a separate PR
3 years ago
decf0fc8ce
Revert using preferred_username
...
It might present a security issue if the users can change this value for themselves. Needs further investigation
3 years ago
21732f213b
Fix shadow issue in CI
3 years ago
08e5ec6ad1
Fix IsAdminGroup comment.
3 years ago
46c1dc80fb
Use map[string]struct{} instead of map[string]bool
3 years ago
aafac179a5
Add test for oidc with preferred usernames.
3 years ago
f730c0bec4
Sanitize usernames
3 years ago
48666792c7
Draft: adding usernames to GetIdentityFunc
3 years ago
79eec83f3e
Rename and reformat to PreferredUsername
3 years ago
09a21fef26
Implement #550
...
- Read `preferred_username` from token
- Add `preferred_username` to the default Usernames
- Check the `admin` array for admin groups that the user might belong to
3 years ago
2336936b5c
Fix typo
3 years ago
9787728fbd
Mask challenge password after it has been read
3 years ago
0487686f69
Merge branch 'master' into hs/scep
3 years ago
2ae43ef2dc
[acme db interface] wip errors
3 years ago
583d60dc0d
Address (most) PR comments
3 years ago
2536a08dc2
Add support for configuring capabilities (cacaps)
3 years ago
e4d7ea8fa0
Add support for challenge password
3 years ago
311c9d767b
Add AuthorizeSign method to SCEP authority
3 years ago
7ad90d10b3
Refactor initialization of SCEP authority
3 years ago
713b571d7a
Refactor SCEP authority initialization and clean some code
3 years ago
ffdd58ea3c
Add rudimentary (and incomplete) support for SCEP
3 years ago
16665c97f0
Allow empty SAN in CSR for validation ...
...
- The default template will always use the SANs from the token.
- If there are any SANs they must be validated against the token.
3 years ago
5017b7d21f
Recalculate token id instead of validating it.
3 years ago
86c947babc
Upgrade crypto and fix test.
3 years ago
0cf594a003
Validate payload ID.
...
Related to #435
3 years ago
39b23c057d
Add all AWS certificates used to verify base64 signatures.
4 years ago
7d1686dc53
Add option to specify the AWS IID certificates to use.
...
This changes adds a new option `iidRoots` that allows a user to
define one or more certificates that will be used for AWS IID
signature validation.
Fixes #393
4 years ago
4c8bf87dc1
Use new admin template for K8ssa and admin-OIDC provisioners.
...
This change replaces the .Insecure.CR template to one that sets
all the SANs, but uses key usages and extended key usages for
regular TLS certificates.
4 years ago
276e307a1d
Add extra tests for CustomSSHTemplateOptions
4 years ago
da9f0b09af
Ignore `null` string for x509 and ssh templateData.
4 years ago
81c6e01269
Fix unit test.
4 years ago
ce9af5c20f
Standardize k8ssa check on issuer name
4 years ago
8ee246edda
Upgrade go.step.sm to v0.4.0
4 years ago
35bd3ec383
Merge pull request #329 from smallstep/ssh-cert-templates
...
SSH cert templates
4 years ago
b7269b6579
Fix comment.
4 years ago
c94a1c51be
Merge branch 'master' into ssh-cert-templates
4 years ago
ba918100d0
Use go.step.sm/crypto/jose
...
Replace use of github.com/smallstep/cli/crypto with the new package
go.step.sm/crypto/jose.
4 years ago
46fc922afd
Remove unused code; fix usage wrong word; add gap time for unit test
4 years ago
d30a95236d
Use always go.step.sm/crypto
4 years ago
aaaa7e9b4e
Merge branch 'master' into cert-templates
4 years ago
e83e47a91e
Use sshutil and randutil from go.step.sm/crypto.
4 years ago
f437b86a7b
Merge branch 'cert-templates' into ssh-cert-templates
4 years ago
c8d225a763
Use x509util from go.step.sm/crypto/x509util
4 years ago
37f84e9bb3
Add delay in test.
4 years ago
8d89bbd62f
Remove unused code.
4 years ago
c4bbc81d9f
Fix authority tests.
4 years ago
413af88aad
Fix provisioning tests.
4 years ago
b66bdfabcd
Enforce an OIDC users to send all template variables.
4 years ago
9822305bb6
Use only the IID template on IID provisioners.
...
Use always sshutil.DefaultIIDCertificate and require at least one
principal on IID provisioners.
4 years ago
aa657cdb4b
Use SSHOptions inside provisioner options.
4 years ago
02379d494b
Add support for extensions and critical options on the identity
...
function.
4 years ago
8ff8d90f8c
On JWK and X5C validate the key id on the request.
4 years ago
a78f7e8913
Add template support on k8ssa provisioner.
4 years ago
6c36ceb158
Add initial template support for iid provisisioners.
4 years ago
8e7bf96769
Fix error prefix.
4 years ago
e0dce54338
Add missing argument.
4 years ago
c1fc45c872
Simplify SSH modifiers with options.
...
It also changes the behavior of the request options to modify only
the validity of the certificate.
4 years ago
ad28f0f59a
Move variable where it is used.
4 years ago
715eb4eacc
Add initial support for ssh templates on OIDC.
4 years ago
c2dc76550c
Add ssh certificate template to X5C provisioner.
4 years ago
380a0d6daf
Add ssh certificate templates to JWK provisioner.
4 years ago
f75a12e10a
Add omitempty tag option.
4 years ago
570ede45e7
Do not enforce number of principals or extensions.
4 years ago
631f1612a1
Add TemplateData to SignSSHOptions.
4 years ago
c6746425a3
Add methods to initialize ssh templates in provisioners.
4 years ago
3e80f41c19
Change provisioner options to have X509 as a field.
4 years ago
86efe7aff0
aws: use http.NoBody instead of nil
...
It's a little more descriptive.
4 years ago
2b121efc8f
aws: test constructor with empty IDMS string array
4 years ago
6c64fb3ed2
Rename provisioner options structs:
...
* provisioner.ProvisionerOptions => provisioner.Options
* provisioner.Options => provisioner.SignOptions
* provisioner.SSHOptions => provisioner.SingSSHOptions
4 years ago
dc39eef721
aws: test badIDMS functional path
...
The existing test only covers the constructor logic. Also test the live
code path that is executed when a bad IDMS version is supplied.
4 years ago
51f16ee2e0
aws: add tests covering metadata service versions
...
* Add constructor tests for the aws provisioner.
* Add a test to make sure the "v1" logic continues to work.
By and large, v2 is the way to go. However, there are some instances of
things that specifically request metadata service version 1 and so this
adds minimal coverage to make sure we don't accidentally break the path
should anyone need to depend on the former logic.
4 years ago
5efe5f3573
metadata-v2: pull in joshathysolate-master
...
Taking of this PR to get it across the goal line.
4 years ago
5ac3f8a160
Add provisioner options tests.
4 years ago
02c4f9817d
Set full token payload instead of only the known properties.
4 years ago
0c8376a7f6
Fix existing unit tests.
4 years ago
a7fe0104c4
Remove ACME restrictions and add proper template support.
4 years ago
cf2989a848
Add token and subject to K8sSA provisioner to be used in custom
...
templates.
4 years ago
71be83b25e
Add iss#sub uri in OIDC certificates.
...
Admin will use the CR template if none is provided.
4 years ago
c58117b30d
Allow to use base64 when defining a template in the ca.json.
4 years ago
b2ca3176f5
Prepend insecure to user and CR variables names.
4 years ago
b11486f41f
Fix option method for template variable.
4 years ago
Herman Slatman
Mariano Cano
Mariano Cano
vijayjt
max furman
Fearghal O Floinn
Cristian Le
David Cowden