Commit Graph

56886 Commits (wip-string)
 

Author SHA1 Message Date
Patric Stout 6e7c92e3af Fix: race-conditions in GUI updates when downloading HTTP files
(cherry picked from commit 56c6df4702015fda7cc7a05b67bfe90b3ede1ad0)

See: https://github.com/OpenTTD/OpenTTD/issues/11636
See: https://github.com/OpenTTD/OpenTTD/pull/11639
5 months ago
Peter Nelson 8ff0bef862
Codechange: Make widget index const to prevent changes. (#11658)
This guards against future widget index manipulation.
5 months ago
translators fd782ada05 Update: Translations from eints
russian: 11 changes by lexuslatvia
finnish: 12 changes by hpiirai
latvian: 217 changes by lexuslatvia
5 months ago
Peter Nelson 6215e9bf77
Fix #11655: Crash due to NWidgetMatrix modifying widget->index. (#11657)
NWidgetMatrix modifies its child widget's index to indicate which element
is to be drawn, which now causes issues with code that does not know about
stuffing extra data into the index.

Instead, let NWidgetMatrix store the currently processing element, and
retrieve this information from the matrix widget while child widgets are
being drawn.

This means only widgets that are children of NWidgetMatrix need to know
anything about their extra data.
5 months ago
Charles Pigott 1e60734660
Fix: Compilation with DEBUG_DUMP_COMMANDS enabled (#11607) 5 months ago
Patric Stout 49db7bbe08 Change: add vcpkg.json to instruct vcpkg what dependencies we require
This works on all OSes, making it far simpler for any developer
to jump in. Just install vcpkg, run "vcpkg install" in our root,
and you have all the dependencies.
5 months ago
Patric Stout 0c064b5119 Change: [CI] use vcpkg built-in caching mechanism 5 months ago
Patric Stout 5d86588a45 Change: [CI] pkg-config is installed by default on latest runner 5 months ago
Patric Stout 086bd00f5d Fix: [CI] upgrade curl to a modern version to avoid patching other tools 5 months ago
Patric Stout 3fec8ece5a Change: [CI] always use "latest" image for our runners 5 months ago
Jonathan G Rennison 673a0dc5de Fix station blocked/pylon/wire bits with CBID_STATION_TILE_LAYOUT 5 months ago
Jonathan G Rennison f3614c419d Fix savegames with incorrect signal always reserve through bits
See: #620
5 months ago
Jonathan G Rennison 8256bb8359 Tracerestrict: Fix share/unshare actions setting always reserve through bit incorrectly
See: #620
5 months ago
Jonathan G Rennison 00a0853550 Debug: Show if signal is always reserve through 5 months ago
Jonathan G Rennison 099a7bdd3a Debug: Add drop-down items to go between road/rail/signal features 5 months ago
Jonathan G Rennison dac4d9a221 Debug: Allow debug feature helpers to provide drop down options
In non sprite dump mode
5 months ago
Patric Stout d6e8e83052
Fix: [CI] patch in SHF_COMPRESSED symbol for our Linux Generic binaries (#11651) 5 months ago
Peter Nelson f3b4d2a384
Fix #11649: Ignore disabling a widget that does not exist. (#11652)
Orders window has different widget layouts depending on vehicle type
which don't all have the same widgets, and therefore it tries to disable
widgets that might not exist.

Restore the old behaviour of ignoring such requests, instead of crashing.
5 months ago
Peter Nelson 268e512fb8 Codechange: Set storage type of widget enums to WidgetID. 5 months ago
Peter Nelson a0dfb76e34 Codechange: Replace mishmash of types for widget index with WidgetID.
Indices were stored as int, but often passed around as uint/uint8_t and casts.

Now they should all use WidgetID.
5 months ago
Peter Nelson fd84f73323
Fix #11643: Empty area at top of survey preview. (#11647)
Empty area at the top of some textfile windows due to calling
SetDisplayedPlane() after calling FinishInitNested(), and/or changing
the displayed plane and not calling ReInit() after.

This was previously hidden by CheckForMissingGlyphs() reinitialising
all windows anyway.
5 months ago
Jonathan G Rennison e62c912c10 Fix off-by-one/buffer over-read error in StrMakeValid
See: https://github.com/OpenTTD/OpenTTD/issues/11644
5 months ago
Jonathan G Rennison 74a2cd5123 Fix thread safety issues in GetLogPrefix 5 months ago
Jonathan G Rennison 3683fdce6a Bump OpenTTD content version to 13.4 5 months ago
Jonathan G Rennison 383a21de9e CMake: Exclude SURVEY_KEY from version info 5 months ago
Jonathan G Rennison f47a4e7cbd CMake: Fix binfiles not being included in build 5 months ago
Jonathan G Rennison 201ddf4c08 Merge branch 'master' into jgrpp
# Conflicts:
#	src/widget.cpp
5 months ago
Peter Nelson b86182ab84 Codechange: Use std::map to provide indexed widget access.
This removes the need to determine the biggest widget index and replaces C-style memory handling.
5 months ago
Peter Nelson a12f426d69 Codechange: Rename nested array to widget lookup.
This changes from naming storage-type to naming functionality.

* `FillNestedArray` is renamed to `FillWidgetLookup`.
* `Window::nested_array` is renamed to `Window::widget_lookup`.
* `array` parameter renamed as well.
5 months ago
translators a8e587632a Update: Translations from eints
danish: 3 changes by bscargo
dutch: 10 changes by Afoklala
5 months ago
Jonathan G Rennison b49f8c6bfc Avoid O(N^2) in group livery propagation 5 months ago
Jonathan G Rennison ffff696b4e Merge branch 'master' into jgrpp
# Conflicts:
#	src/build_vehicle_gui.cpp
#	src/cheat_gui.cpp
#	src/console_cmds.cpp
#	src/crashlog.cpp
#	src/date_gui.cpp
#	src/engine.cpp
#	src/group_cmd.cpp
#	src/landscape.cpp
#	src/network/network_gui.cpp
#	src/newgrf.cpp
#	src/saveload/afterload.cpp
#	src/script/api/script_date.cpp
#	src/sl/oldloader_sl.cpp
#	src/station_cmd.cpp
#	src/station_cmd.h
#	src/strings.cpp
#	src/subsidy_gui.cpp
#	src/survey.cpp
#	src/timer/timer_game_calendar.cpp
#	src/timer/timer_game_calendar.h
5 months ago
Peter Nelson feb94d233d
Codechange: Remove deferred nested_array initialization path. (#11640)
Having two ways (`FillNestedArray` and `SetupSmallestSize`) to initialize
`Window::nested_array` introduces confusion.

Instead, make `FillNestedArray` the canonical way, always call it, and remove
init_array from `SetupSmallestSize`.
5 months ago
Patric Stout 11ba951250
Fix: race-condition when creating new HTTP requests from different threads (#11638) 5 months ago
Jonathan G Rennison 0776d7e992 Disallow converting far end of tunnel/bridge road/tram when owned by other
When adding road across or converting road/tram type
5 months ago
Jonathan G Rennison decfab153a Settings: Fix duplication of PLYX save field table 5 months ago
Jonathan G Rennison ec6d2b68de Fix infrastructure totals when connecting road/tram of different owners
across dual road/tram bridge with custom bridge heads
5 months ago
Jonathan G Rennison 2810c4fe65 Simplify infrastructure updates in tunnel/bridge road/tram conversion 5 months ago
Peter Nelson 5d2ed80c95 Fix: Changing group parent did not properly update partially-default liveries. 5 months ago
Peter Nelson bfb4254226 Fix: Changing default livery did not propagate to group liveries.
#11614 attempted to address this but did not handle 2CC properly, and changes to the default livery were not handled.
5 months ago
Jonathan G Rennison 3b18877b87
Fix #11629: AirportGetNearestTown for rotated airports (#11631)
Add rotation parameter to AirportGetNearestTown
Add wrapper for existing stations
Remove unnecessary iterator cloning
5 months ago
Peter Nelson 33ff64ef74
Codechange: Simplify ConvertDateToYMD by returning YearMonthDay instead of outputting to a pointer. (#11637) 5 months ago
Peter Nelson bd3b28551e Codechange: Replace reliability magic numbers with constants.
These are derived as a percentage of UINT16_MAX.
5 months ago
Peter Nelson 7b2c143df0 Fix: Prevent underflow if engine base life is less than 8 years. 5 months ago
translators ead5ad119c Update: Translations from eints
english (au): 11 changes by krysclarke
danish: 9 changes by bscargo
portuguese (brazilian): 10 changes by pasantoro
5 months ago
Jonathan G Rennison 6a94f2f3e7 Fix 35d2842d: Fix script handling of airport rotations
Adjust types/signature
5 months ago
Jonathan G Rennison b72366419b Merge branch 'master' into jgrpp
# Conflicts:
#	src/blitter/32bpp_anim.cpp
#	src/blitter/8bpp_optimized.cpp
#	src/gfx.cpp
#	src/gfx_func.h
#	src/gfxinit.cpp
#	src/network/core/os_abstraction.cpp
#	src/spritecache.cpp
5 months ago
Jonathan G Rennison 507fd1839c Change minimum value for auto_timetable_separation_rate setting 5 months ago
Jonathan G Rennison 6edde70b04 Scheduled dispatch: Add company setting to set default schedule duration 5 months ago
Jonathan G Rennison 821a7c73ef Lang: Add default-translation tag for "Default" texts 5 months ago