TouchMenu: TouchMenuItem's UnderlineContainer should probably have its own dimen object

The coordinates could wonky otherwise, as TouchMenuItem is an
InputContainer.
Mostly harmless in practice as that UC is its main widget.
reviewable/pr11044/r7
NiLuJe 4 months ago
parent 4785df48a9
commit 39744d7642

@ -12,7 +12,7 @@ local WidgetContainer = require("ui/widget/container/widgetcontainer")
local UnderlineContainer = WidgetContainer:extend{ local UnderlineContainer = WidgetContainer:extend{
linesize = Size.line.thick, linesize = Size.line.thick,
padding = Size.padding.tiny, padding = Size.padding.tiny,
--- @todo shouldn't this default to black instead? -- We default to white to be invisible by default for FocusManager use-cases (only switching to black @ onFocus)
color = Blitbuffer.COLOR_WHITE, color = Blitbuffer.COLOR_WHITE,
vertical_align = "top", vertical_align = "top",
} }

@ -145,8 +145,8 @@ function TouchMenuItem:init()
self._underline_container = UnderlineContainer:new{ self._underline_container = UnderlineContainer:new{
vertical_align = "center", vertical_align = "center",
dimen = self.dimen, dimen = self.dimen:copy(),
self.item_frame self.item_frame,
} }
self[1] = self._underline_container self[1] = self._underline_container

Loading…
Cancel
Save