Fix: Crash when highlight a word (#3155)

* Fix: Crash when highlight a word

* reorganize highlight strings

* Remove redundant var
pull/3162/head
Robert 7 years ago committed by Frans de Jonge
parent a003b375c2
commit 568e8f667a

@ -58,6 +58,11 @@ local DictQuickLookup = InputContainer:new{
refresh_callback = nil, refresh_callback = nil,
} }
local highlight_strings = {
highlight =_("Highlight"),
unhighlight = _("Unhighlight"),
}
function DictQuickLookup:init() function DictQuickLookup:init()
self:changeToDefaultDict() self:changeToDefaultDict()
if Device:hasKeys() then if Device:hasKeys() then
@ -330,7 +335,7 @@ function DictQuickLookup:update()
text = self:getHighlightText(), text = self:getHighlightText(),
enabled = true, enabled = true,
callback = function() callback = function()
if self:getHighlightText() == "Highlight" then if self:getHighlightText() == highlight_strings.highlight then
self.ui:handleEvent(Event:new("Highlight")) self.ui:handleEvent(Event:new("Highlight"))
else else
self.ui:handleEvent(Event:new("Unhighlight")) self.ui:handleEvent(Event:new("Unhighlight"))
@ -481,11 +486,11 @@ end
function DictQuickLookup:getHighlightText() function DictQuickLookup:getHighlightText()
local item = self:getHighlightedItem() local item = self:getHighlightedItem()
if not item then if not item then
return _("Highlight"), false return highlight_strings.highlight, false
elseif self.ui.bookmark:isBookmarkAdded(item) then elseif self.ui.bookmark:isBookmarkAdded(item) then
return _("Unhighlight"), false return highlight_strings.unhighlight, false
else else
return _("Highlight"), true return highlight_strings.highlight, true
end end
end end

Loading…
Cancel
Save